configure has bogus windres version check (gcc)

NEW
Unassigned

Status

defect
11 years ago
a year ago

People

(Reporter: Mook, Unassigned)

Tracking

Trunk
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

11 years ago
configure looks for the windres version this way:
_WINDRES_VERSION=`${WINDRES} --version 2>&1 | grep -i windres 2>/dev/null | $AWK '{ print $3 }'`

Unfortunately, windres --version says:
GNU windres (GNU Binutils) 2.18.50.20080907

This means that configure ends up trying to parse "(GNU" as a version string.  This unintentionally passes all the checks and keeps going anyway :)

Using something like _MSVC_VER_FILTER would probably be more fruitful.
This line still appears in old-configure.in. What I'm not sure of is the conditions where the version detection fails and whether we care.

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.