Failed to compilejstracer on Linux-64, DEBUG build

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: igor, Assigned: igor)

Tracking

unspecified
x86
Linux
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 337416 [details] [diff] [review]
fix

the current code contains:

#if defined(DEBUG) && defined(NANOJIT_IA32)
    uint64 cycles = rdtsc() - start;
#else
    debug_only_v(uint64 cycles = 0;)
#endif

    debug_only_v(printf("leaving trace at %s:%u@%u, op=%s, lr=%p, exitType=%d, sp=%d, ip=%p, "
                        "cycles=%llu\n",
...
                        cycles));


That uint64 cycles = 0; does not work given definition of debug_only_v:

#define debug_only_v(x) if (verbose_debug) { x; }

The attached patch fixes that by printing cycles only for ia32.
Attachment #337416 - Flags: review+
(Assignee)

Comment 1

10 years ago
landed - http://hg.mozilla.org/mozilla-central/rev/d87cf8e2bd02
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.