Closed Bug 454163 Opened 16 years ago Closed 16 years ago

Failed to compilejstracer on Linux-64, DEBUG build

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: igor, Assigned: igor)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
the current code contains:

#if defined(DEBUG) && defined(NANOJIT_IA32)
    uint64 cycles = rdtsc() - start;
#else
    debug_only_v(uint64 cycles = 0;)
#endif

    debug_only_v(printf("leaving trace at %s:%u@%u, op=%s, lr=%p, exitType=%d, sp=%d, ip=%p, "
                        "cycles=%llu\n",
...
                        cycles));


That uint64 cycles = 0; does not work given definition of debug_only_v:

#define debug_only_v(x) if (verbose_debug) { x; }

The attached patch fixes that by printing cycles only for ia32.
Attachment #337416 - Flags: review+
landed - http://hg.mozilla.org/mozilla-central/rev/d87cf8e2bd02
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: