454224 - support for dragging canvases not in documents

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Neil Deakin]

Attachment: allow drag feedback to be a canvas not in a document

You should be able to create a <canvas> and use that as drag image feedback. Right now, it only works if you insert the canvas in the document, which is less useful.

This was supported at one point when implementing drag feedback, but somehow this piece got removed during a patch iteration.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 337453 [details] [diff] [review]
allow drag feedback to be a canvas not in a document

Fine.

But I think you should use an offscreen surface (via gfxPlatform::CreateOffscreenSurface) instead of an image surface. And either way, you shouldn't need to clear it, it should be clear when created.

Comment 2

[Neil Deakin]

(In reply to comment #1)
> (From update of attachment 337453 [details] [diff] [review])
> Fine.
> 
> But I think you should use an offscreen surface (via
> gfxPlatform::CreateOffscreenSurface) instead of an image surface. And either
> way, you shouldn't need to clear it, it should be clear when created.

Sure, we can file a bug on improving this code. The clearing code was needed for Linux otherwise there was garbage in the image. It's quite possible that has improved since to no longer be an issue.

Comment 3

[Neil Deakin]

Need to make a manual test for this.