Closed Bug 454224 Opened 13 years ago Closed 13 years ago

support for dragging canvases not in documents

Categories

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file)

You should be able to create a <canvas> and use that as drag image feedback. Right now, it only works if you insert the canvas in the document, which is less useful.

This was supported at one point when implementing drag feedback, but somehow this piece got removed during a patch iteration.
Attachment #337453 - Flags: superreview?(roc)
Attachment #337453 - Flags: review?(roc)
Attachment #337453 - Flags: superreview?(roc)
Attachment #337453 - Flags: superreview+
Attachment #337453 - Flags: review?(roc)
Attachment #337453 - Flags: review+
Comment on attachment 337453 [details] [diff] [review]
allow drag feedback to be a canvas not in a document

Fine.

But I think you should use an offscreen surface (via gfxPlatform::CreateOffscreenSurface) instead of an image surface. And either way, you shouldn't need to clear it, it should be clear when created.
(In reply to comment #1)
> (From update of attachment 337453 [details] [diff] [review])
> Fine.
> 
> But I think you should use an offscreen surface (via
> gfxPlatform::CreateOffscreenSurface) instead of an image surface. And either
> way, you shouldn't need to clear it, it should be clear when created.

Sure, we can file a bug on improving this code. The clearing code was needed for Linux otherwise there was garbage in the image. It's quite possible that has improved since to no longer be an issue.
Blocks: 454407
Need to make a manual test for this.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.