454277 - TM: fix for V8/raytrace.js regressed access-binary-trees by 2x

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Robert Sayre]

Bisection points to this revision by Brendan:

http://hg.mozilla.org/tracemonkey/rev/15a142de1b33

Comment 1

[Brendan Eich [:brendan]]

C'mon, no way! :-P

That patch needs this followup for JSOP_NOT tracing:

http://hg.mozilla.org/tracemonkey/rev/b776e26bb8ea

landed for bug 454044. But that didn't help access-binary-trees. Either of the two changes here could have led to more tracing.

I now see only two aborts due to unknown native (math_max -- Rob, could you please file a bug on this one? Anyone who has added a jsbuiltin could do it -- thanks).

Andreas, can you take this one? My plate is full, but I suspect this is up your current alley (recursion).

/be

/be

Comment 2

[Brendan Eich [:brendan]]

Forgot to add that I have patches in place, they may be making access-binary-trees abort less. But it still is half as fast as it used to be.

/be

Comment 3

[Andreas Gal :gal]

Its recursive and it should be about 100% of original speed (no speedup, no slowdown). Trying to catch up with TM tip patches and then I can take care of the builtin.

Comment 4

[Andreas Gal :gal]

Pulling & building. My guess is we don't abort where we should (until we support recursion).

Comment 5

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/73a0e8ebcbee

Closed. Recursion work will be tracked with a separate bug.