Closed
Bug 454279
Opened 16 years ago
Closed 16 years ago
clean up ns4xPlugin code
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file, 2 obsolete files)
|
24.69 KB,
patch
|
Details | Diff | Splinter Review |
I was reading through ns4xPlugin.h/cpp and it could use some cleanup. The following patch removes a member var, cleans up style and comments, and better organizes some pieces of code. The files are much easier to look at with this. The one behavior change is that we no longer look for NP_PluginInit, which was a naming mistake early in NPAPI development. I don't think we need to support that any more so we should clean it up to reduce potential for confusion.
Attachment #337516 -
Flags: superreview?(jst)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 337516 [details] [diff] [review] fix v1.0 Looks good!
Attachment #337516 -
Flags: superreview?(jst)
Attachment #337516 -
Flags: superreview+
Attachment #337516 -
Flags: review+
fix a reversed ifdef I caught before checkin
Attachment #337516 -
Attachment is obsolete: true
move old integer types to new C99 types
Attachment #338042 -
Attachment is obsolete: true
landed on trunk
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•