454282 - affiliates tab doesn't show active state

Status: RESOLVED WONTFIX

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Alex Buchanan [:abuchanan]]

when you click on the 'affiliates' tab in the main navigation on sfx.com, it should show as active (turn white, blend in with lower half of header), but it doesn't

Comment 1

[Paul Booker]

I couldn't fix this !

From looking @ page.tpl.php and page-front.tpl.php i can see that 

<li class="menu-1-3-2"><a href="/events-home" title="Welcome to Firefox Marketing Events" class="menu-1-3-2"><span>Events</span></a></li>

corresponds to a item in style.css like

#navigation ul.primary-links li.menu-1-3-2-active a span,


so it looks as though the affiliate links need to be something like affiliates-homepage instead of affilaites/homepage so first i changed the links in the template and setup a  url alias , cleared the cache  but that didn't work.

I also tried changing the links in the affiliate module and trying different type of menu 'types'.

So it looks as though i have missed the obvious somewhere and need to be hit on the head , please feel free to strike a blow 

Paul

Comment 2

[Alex Buchanan [:abuchanan]]

The navigation is actually hard coded in page.tpl.php (and really shouldn't be, why is it?) so making changes from within drupal won't have any effect.

The HTML doesn't actually correspond to the CSS, because the <li> doesn't have the menu-1-3-2-active class.

an example of one that works...

#navigation #page-og ul.primary-links li.menu-1-2-2 a, #navigation #page-events-home ul.primary-links li.menu-1-3-2 a, #navigation #page-stats ul.primary-links li.menu-1-4-2 a, #navigation #page-materials ul.primary-links li.menu-1-5-2 a, #navigation #page-faq ul.primary-links li.menu-1-6-2 a

notice the #page-og, #page-events-home.  this is what makes it active.  a pretty odd, cluttery way to do things IMO.

Comment 3

[Paul Booker]

The navigation is actually hard coded in page.tpl.php (and really shouldn't be,
why is it? ..  i don't know , ill investigate

I understand how the other works any idea how to fix the problem ?

Comment 4

[Alex Buchanan [:abuchanan]]

a quick fix would be add a CSS rule like,

#navigation #page-affiliates-homepage ul.primary-links li.menu-1-2-2 a

to the corresponding rules in style.css

The problem is the rules exist for og, events, etc affiliates just isn't in the list

Comment 5

[Paul Booker]

Thanks Alex ,

It should work to my mind but its not working on my local server. I'll look at this again tomorrow.

Comment 6

[Paul Booker]

Attachment: A patch to resolve the problem.

A patch to resolve the problem.

Note:
After the patch is applied CSS file aggregation needs to be disabled an renabled
@ admin/settings/performance

Comment 7

[Paul Booker]

Attachment: A patch to resolve the problem.

Comment 8

[Paul Booker]

As focus is on migrating the spreadfirefox site to D6 ill resolve this bug as wontfix.

Comment 9

[Alex Buchanan [:abuchanan]]

Comment on attachment 341966 [details] [diff] [review]
A patch to resolve the problem. 

cleaning out the review queue