viewSource throws when view_source.editor.external pref does not exist

RESOLVED FIXED in mozilla1.9.1b1

Status

()

Toolkit
View Source
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mcsmurf, Assigned: philor)

Tracking

Trunk
mozilla1.9.1b1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
The viewSource function in viewSourceUtils.js was changed recently and now tries to read the pref view_source.editor.external pref. Some apps do not have that pref though as it was added to Firefox only. So either add this pref to all.js or wrap this code into a try...catch.
(Assignee)

Comment 1

9 years ago
Created attachment 337597 [details] [diff] [review]
Fix v.1

What ever happened to all that talk about having a toolkit.js prefs file for... toolkit prefs?
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #337597 - Flags: review?(gavin.sharp)
Attachment #337597 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 2

9 years ago
http://hg.mozilla.org/mozilla-central/rev/8cea35a2124a
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → mozilla1.9.1b1
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.