Closed
Bug 454320
Opened 17 years ago
Closed 17 years ago
top level test targets should support specifying a test path
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file)
1.44 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
something like |make mochitest-plain TEST_PATH=path/to/test/file.html| would be nice
browser tests make things a bit complicated because the path is a bit different from chrome and mochitests though..
Assignee | ||
Comment 1•17 years ago
|
||
Figured out a way to make browser tests OK too.
Attachment #337577 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•17 years ago
|
Whiteboard: [has patch][needs review ted]
Assignee | ||
Comment 2•17 years ago
|
||
The other option here is to support SOLO_FILE for everything but browser tests. That would keep us inline with check-one and check-interactive. We'd still want to use TEST_PATH for browser tests since you cannot run a single test.
Updated•17 years ago
|
Attachment #337577 -
Flags: review?(ted.mielczarek) → review+
Comment 3•17 years ago
|
||
A SOLO_FILE addition would be nice, but we'd have to hack that into mochitest first. (I'm sure we could hack it into browser-chrome as well.)
Assignee | ||
Comment 4•17 years ago
|
||
(In reply to comment #3)
> A SOLO_FILE addition would be nice, but we'd have to hack that into mochitest
> first. (I'm sure we could hack it into browser-chrome as well.)
It already works for chrome and mochitests. If you specify one test in TEST_PATH, it works just fine (and only runs that test)
Whiteboard: [has patch][needs review ted] → [has patch][has review]
Comment 5•17 years ago
|
||
Ah, I didn't know that. Anyway, I'm sure gavin would support adding that functionality to browserchrome.
Comment 6•17 years ago
|
||
(but that doesn't need to block this work)
Assignee | ||
Comment 7•17 years ago
|
||
Cool (since I'm using this as part of my presentation at Seneca since it is way easier to run one test this way than the current method)
Assignee | ||
Comment 8•17 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/07cb359d26bc
Flags: in-testsuite-
Flags: in-litmus-
Whiteboard: [has patch][has review]
Assignee | ||
Comment 9•17 years ago
|
||
keep forgetting to mark fixed...
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Component: Testing → Build Config
QA Contact: testing → build-config
Comment 10•16 years ago
|
||
Comment on attachment 337577 [details] [diff] [review]
v1.0
>diff --git a/browser/build.mk b/browser/build.mk
>+# Browser tests live in a slightly different location, so we correct the path
>+ifdef TEST_PATH
>+BROWSER_TEST_PATH = --test-path=../browser/$(TEST_PATH)
This "correction" isn't necessary, --test-paths are sourcedir-relative just like normal mochitests. It only happens to work because it always ends up being "browser/../browser".
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•