454320 - top level test targets should support specifying a test path

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Shawn Wilsher :sdwilsh]

something like |make mochitest-plain TEST_PATH=path/to/test/file.html| would be nice

browser tests make things a bit complicated because the path is a bit different from chrome and mochitests though..

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Figured out a way to make browser tests OK too.

Comment 2

[Shawn Wilsher :sdwilsh]

The other option here is to support SOLO_FILE for everything but browser tests.  That would keep us inline with check-one and check-interactive.  We'd still want to use TEST_PATH for browser tests since you cannot run a single test.

Comment 3

[(not currently active) Ted Mielczarek]

A SOLO_FILE addition would be nice, but we'd have to hack that into mochitest first. (I'm sure we could hack it into browser-chrome as well.)

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> A SOLO_FILE addition would be nice, but we'd have to hack that into mochitest
> first. (I'm sure we could hack it into browser-chrome as well.)
It already works for chrome and mochitests.  If you specify one test in TEST_PATH, it works just fine (and only runs that test)

Comment 5

[(not currently active) Ted Mielczarek]

Ah, I didn't know that. Anyway, I'm sure gavin would support adding that functionality to browserchrome.

Comment 6

[(not currently active) Ted Mielczarek]

(but that doesn't need to block this work)

Comment 7

[Shawn Wilsher :sdwilsh]

Cool (since I'm using this as part of my presentation at Seneca since it is way easier to run one test this way than the current method)

Comment 8

[Shawn Wilsher :sdwilsh]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/07cb359d26bc

Comment 9

[Shawn Wilsher :sdwilsh]

keep forgetting to mark fixed...

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 337577 [details] [diff] [review]
v1.0

>diff --git a/browser/build.mk b/browser/build.mk

>+# Browser tests live in a slightly different location, so we correct the path
>+ifdef TEST_PATH
>+BROWSER_TEST_PATH = --test-path=../browser/$(TEST_PATH)

This "correction" isn't necessary, --test-paths are sourcedir-relative just like normal mochitests. It only happens to work because it always ends up being "browser/../browser".