Closed
Bug 454376
Opened 16 years ago
Closed 16 years ago
imgLoader.cpp does not compile with Sun Studio 12 on Solaris
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
Attachments
(2 files)
578 bytes,
patch
|
joe
:
review+
vlad
:
superreview+
|
Details | Diff | Splinter Review |
522 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
error message: "../../../../modules/libpr0n/src/imgLoader.cpp", line 296: Error: The function "find" must have a prototype. 1 Error(s) detected.
Updated•16 years ago
|
Attachment #337628 -
Flags: review?(joe) → review+
Attachment #337628 -
Flags: superreview?(vladimir)
Attachment #337628 -
Flags: superreview?(vladimir) → superreview+
pushed http://hg.mozilla.org/mozilla-central/rev/9a974f0ef019
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Although it compiled, we still need -lCstd to make it actually runnable.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #340118 -
Flags: review?(benjamin)
Comment 5•16 years ago
|
||
Comment on attachment 340118 [details] [diff] [review] add -lCrun -lCstd to LDFLAGS for Solaris Not sure this is the best place to put them (OS_LIBS might be better), but I'm not going to be pedantic about it.
Attachment #340118 -
Flags: review?(benjamin) → review+
Pushed: use LIBS instead of LDFLAGS http://hg.mozilla.org/mozilla-central/rev/914b6ce602ee
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•