imgLoader.cpp does not compile with Sun Studio 12 on Solaris

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Assignee

Description

11 years ago
error message:

"../../../../modules/libpr0n/src/imgLoader.cpp", line 296: Error: The function "find" must have a prototype.
1 Error(s) detected.
Assignee

Comment 1

11 years ago
Posted patch patchSplinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #337628 - Flags: review?(joe)
Attachment #337628 - Flags: review?(joe) → review+
Assignee

Updated

11 years ago
Attachment #337628 - Flags: superreview?(vladimir)
Attachment #337628 - Flags: superreview?(vladimir) → superreview+
Assignee

Comment 2

11 years ago
pushed http://hg.mozilla.org/mozilla-central/rev/9a974f0ef019
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee

Comment 3

11 years ago
Although it compiled, we still need -lCstd to make it actually runnable.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 4

11 years ago
Attachment #340118 - Flags: review?(benjamin)

Comment 5

11 years ago
Comment on attachment 340118 [details] [diff] [review]
add -lCrun -lCstd to LDFLAGS for Solaris

Not sure this is the best place to put them (OS_LIBS might be better), but I'm not going to be pedantic about it.
Attachment #340118 - Flags: review?(benjamin) → review+
Assignee

Comment 6

11 years ago
Pushed:
use LIBS instead of LDFLAGS
http://hg.mozilla.org/mozilla-central/rev/914b6ce602ee
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.