454385 - update TC VS2008 project files with VTune config

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Edwin Smith]

Attachment: adds vtune config where needed, use same obj folder structure as other configs

Comment 1

[Rick Reitmaier]

Comment on attachment 337639 [details] [diff] [review]
adds vtune config where needed, use same obj folder structure as other configs

hard to read this, but are there changes to the mobile/x64 builds or are have they just been moved about.

Comment 2

[Edwin Smith]

This is the exact patch you sent me, except I change the output directory setting.  I did noticed you changed the mobile & x86 settings, was that intentional?  maybe not?

Comment 3

[Moh Haghighat]

The patch is rejected for merge on a fresh copy of TC on my win32 system. Any thoughts?

Comment 4

[Moh Haghighat]

The patch is fine. It just needed dos2unix conversion.
Also verified that the VTune build works fine on both sampling and CG.

Comment 5

[Rick Reitmaier]

Thanks for checking Moh.

I need to repost, since we found some mobile changes that shouldn't have been there.   Will do so shortly...

Comment 6

[Steven Johnson]

yeah, the dos/unix stuff is especially painful for VS project files, since they get rewritten by VS as CRLF (and it tends to reorder stuff randomly too, it seems).

I have a utility python script to sniff all my files for CRLF and optionally fix them before checkin (except for .vcproj and .sln files, which sniffs-and-fixes for NON-CRLF lines)... would this be of general use?

Comment 7

[Edwin Smith]

Life is easiest if *.sln and *.vcproj are left alone with windows CRLF line endings, even when checked in.

Comment 8

[Steven Johnson]

Agreed, that's why I verify that they are all-CRLF. (If someone opened them in a Unix text editor to tweak something the line endings can become mixed, which is no fun)

Comment 9

[Rick Reitmaier]

Attachment: update

Fixed to remove all the old Vtune cruft that somehow made it into the project files.

Comment 10

[Edwin Smith]

Comment on attachment 337928 [details] [diff] [review]
update

In the VTune config, on the "general" property page of each project, the output directory should be 

obj/$(ProjectName)/$(ConfigurationName)

like it is for Release, etc.  Currently when you select VTune config, the output directory is

$(ConfigurationName)

Which means the vtune avmplus.exe is put in

platform/win32/VTune/avmplus.exe

instead of

platform/win32/obj/shell/VTune/avmplus.exe

like the other configs

Comment 11

[Edwin Smith]

By the way, aside from that, the project files worked right, build worked, vtune got the good data.  Can't vouch for the winmo targets.

Comment 12

[Rick Reitmaier]

i'll update the output directory and repost.  As for the winmo I removed VTune projects for them.  I asked around and apparently those projects are unused.

Comment 13

[Edwin Smith]

makes sense.  VTune only applies to x86 and x64 anyway.

Comment 14

[Rick Reitmaier]

Attachment: updated

change output dir to obj as per ed's comments above

Comment 15

[Moh Haghighat]

After applying the "updated" patch on a fresh TC, I get the following message during openinig the avmplus2008.sln on Win32.
Is this expected?

The following error has occurred during XML parsing:

File: C:\tamarin-central\MMgc\MMgc2008.vcproj
Line: 35
Column: 4
Error Message:
Custom build rules file 'c:\Program Files\Microsoft Visual Studio 9.0\VC\VCProjectDefaults\armasm.rules' was not found or failed to load.
The file 'C:\tamarin-central\MMgc\MMgc2008.vcproj' has failed to load.

Comment 16

[Rick Reitmaier]

Right; see https://bugzilla.mozilla.org/show_bug.cgi?id=454571 for that bug

Comment 17

[Edwin Smith]

You just need to copy tc/platform/win32/armasm.rules to the VCProjectDefaults folder in your VS2008 installation.  We're not happy at all about this requirement and looking at how to avoid needing to do the file copy, but anyway, that's the fix.

Comment 18

[Edwin Smith]

Comment on attachment 337958 [details] [diff] [review]
updated 

avmplus project still has the incorrect output directory

Comment 19

[Moh Haghighat]

VTune build runs as expected and both sampling and call-graph options work on a few examples. The binary is created at \tamarin-central\platform\win32\obj\shell\VTune\avmplus.exe.

Comment 20

[Rick Reitmaier]

Attachment: forced all configs to use obj/proj/config

Comment 21

[Rick Reitmaier]

pushed :

changeset:   649:4b9303aa54cc
tag:         tip
user:        Rick Reitmaier <[e-mail]>
date:        Tue Sep 16 10:22:00 2008 -0700
summary:     Fix VTune project (bug 454385 r=edwsmith)

Comment 22

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.