IMAP open folder command sends empty arrays to nsIMsgFolderListener::msgsDeleted observers

RESOLVED FIXED in Thunderbird 3.0a3

Status

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

unspecified
Thunderbird 3.0a3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 337664 [details] [diff] [review]
fix

I noticed that I was receiving msgsDeleted notifications with empty arrays every time I opened some IMAP folders.

This is happening because the keys might not actually exist, but still be there in the database. Since the headers themselves aren't in the database, retrieval fails -- this is actually an expected case.

The fix sends notifications only if the array isn't empty.
Attachment #337664 - Flags: superreview?(bienvenu)
Attachment #337664 - Flags: review?(bienvenu)

Updated

10 years ago
Attachment #337664 - Flags: superreview?(bienvenu)
Attachment #337664 - Flags: superreview+
Attachment #337664 - Flags: review?(bienvenu)
Attachment #337664 - Flags: review+

Comment 1

10 years ago
Comment on attachment 337664 [details] [diff] [review]
fix

thx, Sid.
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Checked in, changeset id: 300:fcd162a95dbf
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
You need to log in before you can comment on or make changes to this bug.