Closed Bug 454407 Opened 15 years ago Closed 14 years ago

Improve surface creation and drawing code in nsBaseDragService::DrawDragForImage

Categories

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Product:
Core
Component:
DOM: Copy & Paste and Drag & Drop
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file)

switch to an offscreen surface
908 bytes, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review 
From bug 454224:

> But I think you should use an offscreen surface (via
> gfxPlatform::CreateOffscreenSurface) instead of an image surface. And either
> way, you shouldn't need to clear it, it should be clear when created.
Another bug removed the clearing code, so the only change needed here is to use an offscreen surface instead of an image surface. Seems to work on all platforms.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #373854 - Flags: superreview?(roc)
Attachment #373854 - Flags: review?(roc)
Attachment #373854 - Flags: superreview?(roc)
Attachment #373854 - Flags: superreview+
Attachment #373854 - Flags: review?(roc)
Attachment #373854 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.