Improve surface creation and drawing code in nsBaseDragService::DrawDragForImage

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: enndeakin, Assigned: enndeakin)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
From bug 454224:

> But I think you should use an offscreen surface (via
> gfxPlatform::CreateOffscreenSurface) instead of an image surface. And either
> way, you shouldn't need to clear it, it should be clear when created.
(Assignee)

Comment 1

10 years ago
Created attachment 373854 [details] [diff] [review]
switch to an offscreen surface

Another bug removed the clearing code, so the only change needed here is to use an offscreen surface instead of an image surface. Seems to work on all platforms.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #373854 - Flags: superreview?(roc)
Attachment #373854 - Flags: review?(roc)
Attachment #373854 - Flags: superreview?(roc)
Attachment #373854 - Flags: superreview+
Attachment #373854 - Flags: review?(roc)
Attachment #373854 - Flags: review+
(Assignee)

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.