Status

Core Graveyard
Security: UI
RESOLVED FIXED
9 years ago
a year ago

People

(Reporter: (dormant account), Assigned: kaie)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
Created attachment 337686 [details] [diff] [review]
fixes

The only thing I'm not sure about is the rv return fix in prbool func in nsPKCS12Blob.cpp as the original's logic is weird due to rv/prbool confusion.
Attachment #337686 - Flags: review?(kaie)
(Assignee)

Comment 1

9 years ago
(In reply to comment #0)
> The only thing I'm not sure about is the rv return fix in prbool func in
> nsPKCS12Blob.cpp as the original's logic is weird due to rv/prbool confusion.

I agree. It seems all active code completely ignores the return value of function handleError(). Only some disabled code tried to look at it.

I propose to change handleError() to have return type "void" and change the return statements to simply "return;"
(Reporter)

Comment 2

9 years ago
That sounds good, could you do that change? Changing return statements is easy. I'm not familiar with the code an unsure of what the logic should for places that do check handleError's return value.
(Assignee)

Comment 3

9 years ago
There are no places where the return value of handleError gets checked.
(Reporter)

Comment 4

9 years ago
Created attachment 337973 [details] [diff] [review]
fixes

You are right, I was confusing it with some unrelated handleError
Attachment #337686 - Attachment is obsolete: true
Attachment #337973 - Flags: review?(kaie)
Attachment #337686 - Flags: review?(kaie)
(Reporter)

Comment 5

9 years ago
Kai, I'm waiting on your review so I can commit this.
(Assignee)

Updated

9 years ago
Attachment #337973 - Flags: review?(kaie) → review+
(Assignee)

Comment 6

9 years ago
Comment on attachment 337973 [details] [diff] [review]
fixes

r=kaie

Please also delete the unnecessary declaration of variable keepGoing.

Thanks a lot for the patch!
(Reporter)

Comment 7

9 years ago
pushed 3e7b639abe75
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.