Closed Bug 454419 Opened 12 years ago Closed 12 years ago

prbool bugs in security/

Categories

(Core Graveyard :: Security: UI, defect)

Other
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: taras.mozilla, Assigned: KaiE)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch fixes (obsolete) — Splinter Review
The only thing I'm not sure about is the rv return fix in prbool func in nsPKCS12Blob.cpp as the original's logic is weird due to rv/prbool confusion.
Attachment #337686 - Flags: review?(kaie)
(In reply to comment #0)
> The only thing I'm not sure about is the rv return fix in prbool func in
> nsPKCS12Blob.cpp as the original's logic is weird due to rv/prbool confusion.

I agree. It seems all active code completely ignores the return value of function handleError(). Only some disabled code tried to look at it.

I propose to change handleError() to have return type "void" and change the return statements to simply "return;"
That sounds good, could you do that change? Changing return statements is easy. I'm not familiar with the code an unsure of what the logic should for places that do check handleError's return value.
There are no places where the return value of handleError gets checked.
Attached patch fixesSplinter Review
You are right, I was confusing it with some unrelated handleError
Attachment #337686 - Attachment is obsolete: true
Attachment #337973 - Flags: review?(kaie)
Attachment #337686 - Flags: review?(kaie)
Kai, I'm waiting on your review so I can commit this.
Attachment #337973 - Flags: review?(kaie) → review+
Comment on attachment 337973 [details] [diff] [review]
fixes

r=kaie

Please also delete the unnecessary declaration of variable keepGoing.

Thanks a lot for the patch!
pushed 3e7b639abe75
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.