454441 - Password manager using too much memory.

Status: RESOLVED WORKSFORME

(Toolkit :: Password Manager, defect)

Description

[Oleg Romashin (:romaxa)]

I don't know is it a real problem or no, but after switching of microb browser on new password manager, browser start to use ~17Mb more in RAM.

Testcase is simple. open browser (news.google.com) and check memory usage:
top, cat /proc/[PID]/status
close browser mv components/nsLogin* /tmp/
open browser again (news.google.com)
top, cat /proc/[PID]/status

on N810 I found next difference in memory usage:

With nsLogin*:
1946 user     SW      135M  1928  0.0109.2 xulrunner-bin
Groups:	20 29 44 29999 
VmPeak:	  140052 kB
VmSize:	  138876 kB
VmLck:	       0 kB
VmHWM:	   29024 kB
VmRSS:	   28708 kB
VmData:	   92820 kB
VmStk:	      84 kB
VmExe:	      68 kB
VmLib:	   36728 kB
VmPTE:	      80 kB
Threads:	7
*****************************
Without nsLogin*:
2007 user     SW      118M  2005  1.6 95.5 xulrunner-bin
VmPeak:	  122836 kB
VmSize:	  121412 kB
VmLck:	       0 kB
VmHWM:	   28020 kB
VmRSS:	   27464 kB
VmData:	   76200 kB
VmStk:	      84 kB
VmExe:	      68 kB
VmLib:	   36024 kB
VmPTE:	      74 kB
Threads:	5

Comment 1

[Justin Dolske [:Dolske]]

Is this with a current trunk build? Are there any stored logins in the profile you're testing with?

I can't imagine how it would be using anywhere near 17MB. The storage-Legacy.js code keeps all the stored logins in memory, but you'd need an absurd number of logins to use that much memory. The newer storage-mozStorage.js is using sqlite, which shouldn't have that problem.

tracemalloc + bloatdiff would help narrow down what the problem is, as might a DTrace object creation log.

Comment 2

[Oleg Romashin (:romaxa)]

(In reply to comment #1)
> Is this with a current trunk build? Are there any stored logins in the profile
> you're testing with?
> 
I'm cleaning profile completely before starting browser

Comment 3

[Oleg Romashin (:romaxa)]

Something is wrong with my environment.... I need to check it again.