454475 - Fix "unhandled enumeration value" warnings in layout/

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Arpad Borsos [:Swatinem]]

Attachment: patch

GCC complains about a lot of unhandled enumeration values. Some bogus default cases can easily silence those warnings.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Have you checked that we shouldn't be handling the other cases here? If so, I'd like to see comments explaining why we don't need to handle any other cases.

Comment 2

[Arpad Borsos [:Swatinem]]

Attachment: added comments

I added the unhandled values directly to the switches instead of using default in most of the cases. Added comments to most cases.
eCSSUnit_Local_Font and eCSSUnit_Font_Format were added by bug 441469. I believe it's fine to just break at those cases.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+      case ePopupClosed:
+        // aState defaults to "closed"
+        break;

Move the AssignLiteral("closed") down to here. And put in a 'default:' clause which does NS_NOTREACHED("Bad popup state").

Comment 4

[Arpad Borsos [:Swatinem]]

Attachment: v3 [Checkin: Comment 5]

(In reply to comment #3)
> Move the AssignLiteral("closed") down to here. And put in a 'default:' clause
> which does NS_NOTREACHED("Bad popup state").

done.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 338837 [details] [diff] [review]
v3
[Checkin: Comment 5]

http://hg.mozilla.org/mozilla-central/rev/85f88079a4ee