Closed Bug 454475 Opened 14 years ago Closed 14 years ago
Fix "unhandled enumeration value" warnings in layout/
GCC complains about a lot of unhandled enumeration values. Some bogus default cases can easily silence those warnings.
Have you checked that we shouldn't be handling the other cases here? If so, I'd like to see comments explaining why we don't need to handle any other cases.
I added the unhandled values directly to the switches instead of using default in most of the cases. Added comments to most cases. eCSSUnit_Local_Font and eCSSUnit_Font_Format were added by bug 441469. I believe it's fine to just break at those cases.
+ case ePopupClosed: + // aState defaults to "closed" + break; Move the AssignLiteral("closed") down to here. And put in a 'default:' clause which does NS_NOTREACHED("Bad popup state").
(In reply to comment #3) > Move the AssignLiteral("closed") down to here. And put in a 'default:' clause > which does NS_NOTREACHED("Bad popup state"). done.
Comment on attachment 338837 [details] [diff] [review] v3 [Checkin: Comment 5] http://hg.mozilla.org/mozilla-central/rev/85f88079a4ee
Attachment #338837 - Attachment description: v3 → v3 [Checkin: Comment 5]
Severity: normal → minor
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.