454483 - Clean up unused variables in gfx/

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Arpad Borsos [:Swatinem]]

Attachment: patch

Removes some unused vars.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 337755 [details] [diff] [review]
patch

This looks ok,  except for:

>diff -r 33f55a9a82ed gfx/thebes/src/gfxFontUtils.cpp
>--- a/gfx/thebes/src/gfxFontUtils.cpp	Tue Sep 02 17:24:46 2008 +0200
>+++ b/gfx/thebes/src/gfxFontUtils.cpp	Tue Sep 02 17:59:58 2008 +0200
>@@ -295,7 +295,6 @@
>         if (idRangeOffset == 0) {
>             aCharacterMap.SetRange(startCount, endCount);
>         } else {
>-            const PRUint16 idDelta = ReadShortAt16(idDeltas, i);
>             for (PRUint32 c = startCount; c <= endCount; ++c) {
>                 if (c == 0xFFFF)
>                     break;
>@@ -366,7 +365,6 @@
>         EncodingIDUCS4ForMicrosoftPlatform = 10
>     };
> 
>-    PRUint16 version = ReadShortAt(aBuf, OffsetVersion);
>     PRUint16 numTables = ReadShortAt(aBuf, OffsetNumTables);
> 
>     // save the format and offset we want here

This is sort of self-documenting code here, so I would just comment out those two lines instead of removing them entirely, and add another comment line saying "unused" or something.

Comment 2

[Arpad Borsos [:Swatinem]]

Attachment: v2 [Checkin: Comment 3]

(In reply to comment #1)
> (From update of attachment 337755 [details] [diff] [review])
> This is sort of self-documenting code here, so I would just comment out those
> two lines instead of removing them entirely, and add another comment line
> saying "unused" or something.

done.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 337767 [details] [diff] [review]
v2
[Checkin: Comment 3]

http://hg.mozilla.org/mozilla-central/rev/415f1f0f5eb4

with my "extended" nit fixes over yours.