Closed
Bug 454519
Opened 16 years ago
Closed 16 years ago
turn lcms assertions on in debug builds
Categories
(Core :: Graphics: Color Management, defect)
Core
Graphics: Color Management
Tracking
()
RESOLVED
FIXED
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
689 bytes,
patch
|
bholley
:
review+
vlad
:
superreview+
|
Details | Diff | Splinter Review |
right now lcms assertions are based off of a #define that isn't hooked into the full build system. Since we don't want them firing in release builds, we currently turn them off with the #define, but this means that we don't get the help of the assertions in the debug build. This should be fixed.
|
||
Comment 1•16 years ago
|
||
Behaves as expected with either --enable-debug or --disable-debug in my .mozconfig.
Attachment #343315 -
Flags: review?(bholley)
|
|
||
Updated•16 years ago
|
Attachment #343315 -
Flags: superreview?(vladimir)
|
Assignee | |
Comment 2•16 years ago
|
||
Comment on attachment 343315 [details] [diff] [review] #ifdef DEBUG instead of CMS_DEBUG looks good - thanks for taking the time to test it
Attachment #343315 -
Flags: review?(bholley) → review+
Attachment #343315 -
Flags: superreview?(vladimir) → superreview+
|
|
Assignee | |
Comment 3•16 years ago
|
||
pushed to mozilla-central in ecb628b5877d
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
|
|
Assignee | |
Updated•15 years ago
|
Component: GFX → GFX: Color Management
Product: Core Graveyard → Core
QA Contact: general → color-management
You need to log in
before you can comment on or make changes to this bug.
Description
•