turn lcms assertions on in debug builds

RESOLVED FIXED

Status

()

Core
GFX: Color Management
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Bobby Holley (parental leave - send mail for anything urgent), Assigned: Bobby Holley (parental leave - send mail for anything urgent))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

689 bytes, patch
Bobby Holley (parental leave - send mail for anything urgent)
: review+
Details | Diff | Splinter Review
right now lcms assertions are based off of a #define that isn't hooked into the full build system. Since we don't want them firing in release builds, we currently turn them off with the #define, but this means that we don't get the help of the assertions in the debug build. This should be fixed.
Blocks: 455056
Created attachment 343315 [details] [diff] [review]
#ifdef DEBUG instead of CMS_DEBUG

Behaves as expected with either --enable-debug or --disable-debug in my .mozconfig.
Attachment #343315 - Flags: review?(bholley)
Attachment #343315 - Flags: superreview?(vladimir)
Comment on attachment 343315 [details] [diff] [review]
#ifdef DEBUG instead of CMS_DEBUG

looks good - thanks for taking the time to test it
Attachment #343315 - Flags: review?(bholley) → review+
Attachment #343315 - Flags: superreview?(vladimir) → superreview+
pushed to mozilla-central in ecb628b5877d
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
Component: GFX → GFX: Color Management
Product: Core Graveyard → Core
QA Contact: general → color-management
You need to log in before you can comment on or make changes to this bug.