Closed
Bug 454558
Opened 17 years ago
Closed 17 years ago
Null check missing in nsGNOMEShellService::GetShouldCheckDefaultBrowser and SetShouldCheckDefaultBrowser and
Categories
(Firefox :: Shell Integration, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
prefs is not null checked.
I don't understand why nsCOMPtr<nsIPrefService> pserve(do_GetService(NS_PREFSERVICE_CONTRACTID)); fail though.
Flags: blocking1.9.0.3?
cancel requesting blocking, since this only happens with a broken Firefox build and an old compreg.dat file.
Flags: blocking1.9.0.3?
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #338080 -
Flags: superreview?(roc)
Attachment #338080 -
Flags: review?(roc)
Attachment #338080 -
Flags: superreview?(roc)
Attachment #338080 -
Flags: superreview+
Attachment #338080 -
Flags: review?(roc)
Attachment #338080 -
Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Summary: Null check missing in nsGNOMEShellService::GetShouldCheckDefaultBrowser and SetShouldCheckDefaultBrowser and → Null check missing in nsGNOMEShellService::GetShouldCheckDefaultBrowser and SetShouldCheckDefaultBrowser and
You need to log in
before you can comment on or make changes to this bug.
Description
•