Null check missing in nsGNOMEShellService::GetShouldCheckDefaultBrowser and SetShouldCheckDefaultBrowser and

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
prefs is not null checked.

I don't understand why nsCOMPtr<nsIPrefService> pserve(do_GetService(NS_PREFSERVICE_CONTRACTID)); fail though.
Flags: blocking1.9.0.3?
(Assignee)

Comment 1

10 years ago
cancel requesting blocking, since this only happens with a broken Firefox build and an old compreg.dat file.
Flags: blocking1.9.0.3?
(Assignee)

Comment 2

10 years ago
Created attachment 338080 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #338080 - Flags: superreview?(roc)
Attachment #338080 - Flags: review?(roc)
Attachment #338080 - Flags: superreview?(roc)
Attachment #338080 - Flags: superreview+
Attachment #338080 - Flags: review?(roc)
Attachment #338080 - Flags: review+
(Assignee)

Comment 3

10 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/e72c9aaa9efb
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Summary: Null check missing in nsGNOMEShellService::GetShouldCheckDefaultBrowser and SetShouldCheckDefaultBrowser and → Null check missing in nsGNOMEShellService::GetShouldCheckDefaultBrowser and SetShouldCheckDefaultBrowser and
You need to log in before you can comment on or make changes to this bug.