Steps to reproduce problem: 1. Open the Account Manager 2. Click on a Composition & Addressing panel 3. Click on a Composition & Addressing panel for a different account Expected results: LDAP preferences update Actual result: LDAP preferences don't update
Created attachment 337867 [details] [diff] [review] Proposed patch The new widget plays nicely with the default account manager code so we can just rip out all the specialised update code and move all the preference attributes to the UI elements.
Attachment #337867 - Flags: review?(bugzilla) → review-
Comment on attachment 337867 [details] [diff] [review] Proposed patch This looks good and is an improvement, except now the account manager lets me select to use the global preference, but doesn't save it when I click ok, even more confusing, it will even change your preferences to override the global preference.
Created attachment 337961 [details] [diff] [review] Fixed patch Oops, I was so worried about not *reading* the settings correctly that I forgot to check writing :-\ Well, now I know what the genericattr attribute does. I also tweaked the id but I don't actually know whether that was necessary.
Attachment #337961 - Flags: review?(bugzilla) → review+
Attachment #337961 - Flags: review?(philringnalda) → review+
Attachment #337961 - Flags: approval-seamonkey2.0a1?
Attachment #337961 - Flags: approval-seamonkey2.0a1? → approval-seamonkey2.0a1+
Comment on attachment 337961 [details] [diff] [review] Fixed patch Yes, I think we should have this (and I want it for TB as well ;-) )
Pushed changset 75f806a2fe31 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.