454574 - LDAP account preferences don't update if you switch between addressing panels

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Open the Account Manager
2. Click on a Composition & Addressing panel
3. Click on a Composition & Addressing panel for a different account

Expected results: LDAP preferences update

Actual result: LDAP preferences don't update

Comment 1

[[e-mail]]

Attachment: Proposed patch

The new widget plays nicely with the default account manager code so we can just rip out all the specialised update code and move all the preference attributes to the UI elements.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 337867 [details] [diff] [review]
Proposed patch

This looks good and is an improvement, except now the account manager lets me select to use the global preference, but doesn't save it when I click ok, even more confusing, it will even change your preferences to override the global preference.

Comment 3

[[e-mail]]

Attachment: Fixed patch

Oops, I was so worried about not *reading* the settings correctly that I forgot to check writing :-\

Well, now I know what the genericattr attribute does.

I also tweaked the id but I don't actually know whether that was necessary.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 337961 [details] [diff] [review]
Fixed patch

That looks better.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 337961 [details] [diff] [review]
Fixed patch

Yes, I think we should have this (and I want it for TB as well ;-) )

Comment 6

[[e-mail]]

Pushed changset 75f806a2fe31 to comm-central.