Closed Bug 454622 Opened 11 years ago Closed 11 years ago

mail won't download if "Allow anti-virus clients to quarantine individual incoming messages" is checked

Categories

(Thunderbird :: Security, defect, major)

x86
Linux
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0a3

People

(Reporter: glock24, Assigned: Bienvenu)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1
Build Identifier: version 3.0a2 (2008072418)

When downloading a message with an attached file, I get this dialog:

"There was an error downloading the following message:   
From: test@test.com
   Subject: test
 This message may contain a virus or there is not enough disk space. Skip this message?"

If I click on cancel, i get this:

"Unable to write the email to the mailbox. Make sure the file system allows you write privileges, and you have enough disk space to copy the mailbox."

I'm testing Shredder Alpha2 on Linux. No antivirus software is installed.

If the "Allow anti-virus clients to quarantine individual incoming messages" optin is unchecked, all works correctly.

Reproducible: Always

Steps to Reproduce:
1.Go to Edit -> Preferences -> Privacy -> Anti-Virus
2.Check "Allow anti-virus clients to quarantine individual incoming messages" and click "Close"
3.Check mail
Actual Results:  
"There was an error downloading the following message:   
From: test@test.com
   Subject: test
 This message may contain a virus or there is not enough disk space. Skip this message?"

And 

"Unable to write the email to the mailbox. Make sure the file system allows you write privileges, and you have enough disk space to copy the mailbox."

Expected Results:  
Mail downloads correctly.

Only happens with messages that contain attached file(s).
Confirmed on linux/trunk with a pop account, wow! Just sent my self a simple plain text msg.
Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-thunderbird3+
Keywords: regression
Target Milestone: --- → Thunderbird 3.0b1
Severity: critical → major
David, do you have bandwidth to take a look at this?
I guess I'd better - I'll see if I can reproduce it on windows.
Assignee: nobody → bienvenu
Magnus, you can't download a simple plain text msg? Is that with the global inbox or not? I'm not seeing any problems here...
Yup. No global inbox. I wouldn't be surprised if it's linux only...
I'll try this on the mac, but if I can't reproduce it there, I'll need some help from someone with Linux.
I'm running Linux, what help do you need?
I need someone to help with a debugger and figure out what's going on in the code, by setting breakpoints, etc.
Well, my coding skills in Linux are not very good (I'm mainly a perl/php developer), but you tell me what to do and I'll be glad to help.

Guess I'll need the TB source, right?
I tried this on an up to date mac build, with that option turned on - all messages downloaded fine.

Guillermo, I was hoping that someone like Magnus, with an existing debug environment setup, might help me - but if that doesn't happen, I'll take you up on your offer to help, thanks!
Attached patch proposed fix (obsolete) — Splinter Review
I can't remember if there was a better way of getting around this issue...
Attachment #339958 - Flags: superreview?(neil)
Attachment #339958 - Flags: review?(mkmelin+mozilla)
Attachment #339958 - Flags: superreview?(neil)
Attachment #339958 - Flags: review?(mkmelin+mozilla)
Attachment #339958 - Flags: review-
Comment on attachment 339958 [details] [diff] [review]
proposed fix

Unfortunately this doesn't work.

Still hit the this 
http://mxr.mozilla.org/comm-central/source/mailnews/local/src/nsPop3Sink.cpp#847

printf("msgSize:%u tmpDownloadFileSize:%u \n"); says
msgSize:3220623024 tmpDownloadFileSize:138321448
Err, 
printf("msgSize:%u tmpDownloadFileSize:%u \n", msgSize, tmpDownloadFileSize);
msgSize:1984 tmpDownloadFileSize:0

I do have the 1984 byte file in /tmp/newmsg
I don't know why this would behave differently, but can you try this patch instead of the other one? This is what we do in other places.
Attachment #339958 - Attachment is obsolete: true
Comment on attachment 339972 [details] [diff] [review]
do what we do in other places

Yes this fixes it for me, thx!

Nit: capital W.
Attachment #339972 - Flags: superreview?(neil)
Attachment #339972 - Flags: review+
Comment on attachment 339972 [details] [diff] [review]
do what we do in other places

If Neil doesn't get to this today, Dan, can you sr this this afternoon?
Attachment #339972 - Flags: review?(dmose)
Attachment #339972 - Flags: superreview?(neil) → superreview+
thx very much for helping with this, Magnus.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #339972 - Flags: review?(dmose)
You need to log in before you can comment on or make changes to this bug.