Closed Bug 454629 Opened 16 years ago Closed 15 years ago

Email notification of watched topics not working

Categories

(support.mozilla.org :: Forum, task)

Product:
support.mozilla.org
Component:
Forum
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: cilias, Assigned: zzxc)

References

Details

(Whiteboard: sumo_only)

Attachments

(1 file)

This fixes it for me on sumotools
1.04 KB, patch
laura
: review+
Details | Diff | Splinter Review 
1. Go to a discussion in Contributors forum.
2. Click on "Watch this topic".

When someone else posts to that discussion, no email notification is sent.
Target Milestone: --- → 1.1
Chris: this happens on every instance?
I'll try to reproduce. Could you provide a test situation on stage?
Assignee: nobody → paul.craciunoiu
This is specific to the Contributors forum (and perhaps the OT forum). I get notifications for the Firefox forum.

Go to <https://support-stage.mozilla.org/tiki-view_forum_thread.php?locale=en-US&comments_parentId=311255&forumId=3>, and click "Watch this topic" or reply to the post with "Send me an e-mail when someone replies" check marked. Get someone else to post in that thread, and see if you get an email notification.
I got an email notification both ways. This is sample content:
_____________
"test" has posted a reply to a thread you're watching.
You can view the thread and reply at the following URL:

https://support-stage.mozilla.org/tiki-view_forum_thread.php?forumId=3&comments_parentId=311255#threadId311657

Message:
----------------------------------------------------------------------
Testing. Testing...
----------------------------------------------------------------------

If you no longer wish to receive notifications for this thread,
visit the following URL to cancel your subscription:

https://support-stage.mozilla.org/tiki-cancel_watch.php?section=forum&hash=799b7521fb40ddbd9a07a2c4b76de8aa
I'm currently watching that topic so you could post to test I'm getting notifications, as well. If you're watching it and you haven't gotten any notification, perhaps it's a user thing...
Chris - did you confirm that it's broken on stage, too? Waiting for someone to reply on stage to test myself, but want to make sure we know it's not prod-only
(In reply to comment #4)
> I'm currently watching that topic so you could post to test I'm getting
> notifications, as well. If you're watching it and you haven't gotten any
> notification, perhaps it's a user thing...

I noticed you tested with a "regular" account. Obviously the vast majority of posts in the contributor forum will be from contributor accounts. Maybe this is the problem? I posted to the thread with my account, let me know if you see it.  I'm also going to check my watched threads in the regular forum to see if I've been receiving mail there from contributors. Will report back.
(In reply to comment #6)
I replied, I got an email notification from your posting. The account for user "test" is actually a "regular" account. I haven't tested if that one receives notifications, but I could. Let me know if you did, first.
OK, I got your reply. I also tested in the Firefox forum on prod (had someone notify me of a thread they were about to reply to). That went fine as well.

Guess we should test on prod?
As per comment 2, the Firefox forum notifications already worked fine. I just tested with a contributor and it seems to work. Note that the thread we're testing on is in the Contributors forum. Seems that you've tested on the Firefox forum and it works, good to have that confirmation.

It would be good to cover all forums for User and Contributor accounts. I would stick with testing on stage, but you could test on prod, too, as long as it doesn't inconvenience our users. At any rate, to even have a chance of fixing this today I'll need a thread where it doesn't work... so I guess try to think of cases we haven't tested.
Paul - got nothing for the replies you made on prod.
This was broken in OT on prod as well. Clearing all the caches to fix the newsearch problem seemed to fix OT, though I only tested in https://support.mozilla.com/tiki-view_forum_thread.php?comments_parentId=330915&forumId=4

No notifications received in contributor threads, tried a new one and an older one.  Notifications after that still worked in the above OT thread so not a matter of it only working once then breaking again.
Pushing this to 1.2. Waiting for logs on bug 493282. Hope those help.
Target Milestone: 1.1 → 1.2
Laura: I hope you have time to take a look at this :)
Assignee: paul.craciunoiu → laura
Logs didn't give anything more helpful. Is it at all possible that it's still related to cache? That seems most likely except for the fact that all the caches were cleared. Maybe something was missed? or didn't actually clear?

Though I see is that Prod has 399 threads and 3068 posts and stage has 360 threads and 2703 posts. Something in the DB that wasn't copied over could be the problem I guess?
Target Milestone: 1.2 → 1.3
From tracing the code, it seems that only the first forum watch was ever being sent out on production.  This patch fixed it for me on sumotools.
Assignee: laura → bugs
Attachment #384186 - Flags: review?(paul.craciunoiu)
Attachment #384186 - Flags: review?(laura)
Attachment #384186 - Flags: review?(laura) → review+
Comment on attachment 384186 [details] [diff] [review]
This fixes it for me on sumotools

let's try it.
Target Milestone: 1.3 → 1.2
In r28564 / r28567.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: 500583
Comment on attachment 384186 [details] [diff] [review]
This fixes it for me on sumotools

Just going through my r? list
Attachment #384186 - Flags: review?(paulc)
Whiteboard: sumo_only
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: