454638 - Advanced search mode conflicts with normal mode

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Plugins, defect)

Description

[KitchM]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.8.1.15) Gecko/20080623 Firefox/2.0.0.15
Build Identifier: https://bugzilla.mozilla.org/enter_bug.cgi?product=addons.mozilla.org&version=3.2

When selecting the advanced search mode, I entered "news reader" within "News, Feeds & Blogging".  I then entered Firefox, 1.0 to 2.0.  Under Per Page: 100, Platform: Windows, Last Updated: Anytime, and Sort By: Popularity.  
Flaw 1 = The trouble starts when selecting Type: Extension, which changes "within" to "all add-ons".
Flaw 2 = Then the output has nothing to do with "News Reader".
Flaw 3 = If one goes back to "News, Feeds & Blogging" with Type set to all, then the output is better, but still includes inappropriate selections.

My guess is that the granularity of the database is incorrect and/or the search function is poorly programmed.  Else, people are allowed to use the wrong categorization choices for their plug-in entries, which makes for extremely poor search results.

Reproducible: Always

Steps to Reproduce:
1.Follow steps outlined under Details above.
2.
3.
Actual Results:  
See Details above.

Expected Results:  
Should have quickly and simply allowed me to search within the news readers section for all of the news reader add-ons currently available within the parameters listed, and returned only those.

Nothing special in addition.  This is a simple and straight-forward problem that most users can easily duplicate.

Comment 1

[Wil Clouser [:clouserw]]

Attachment: remove select toggle

Here's a patch that fixes this bug.  I guess the question is if people find it more helpful to have the dropdowns reset and lose their specificity or potentially get invalid search results (e.g. searching for a search engine within a category that search engines don't have).

The proper way to fix it would be to load the categories for each type into the JS and it only resets to "all" if someone switches to a non-existant type or category.  I don't think the ROI is worth it at this point in time though so I'll r? morgamic if he wants this to land or not.

Comment 2

[Michael Morgan [:morgamic]]

Comment on attachment 343499 [details] [diff] [review]
remove select toggle

I think we should push this, but it's up to you.

Comment 3

[Wil Clouser [:clouserw]]

WFM, r22007.  Thanks

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Seems fine for me using https://preview.addons.mozilla.org/en-US/firefox/search?q=news+reader&cat=1%2C1&as=true&vfuz=true&appid=1&lver=1.0&hver=2.0&atype=0&pid=4&lup=&pp=100&sort=weeklydownloads; Kitch?

Comment 5

[Wil Clouser [:clouserw]]

Well, I landed the fix.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> Well, I landed the fix.

Yup, I just wanted him to help me verify :-P

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED per comment 4.

Comment 8

[KitchM]

Stephen,
Sorry it took my so long to get back to you.  But it does indeed look good.  After the first item, which was miscategorized, the rest of the page looked pretty right.

Thanks to all who worked on the improvement and fix.