mozillabuild should export APR_ICONV_PATH

VERIFIED FIXED

Status

mozilla.org
MozillaBuild
--
minor
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Régis Caspar, Assigned: ted)

Tracking

Details

(Reporter)

Description

10 years ago
svn cannot be used (encoding problems when trying to diff) with an out of the box mozillabuild install. We should export APR_ICONV_PATH = $MOZILLABUILD\\svn-win32-1.4.2\\iconv somewhere (/etc/profile?)
(Assignee)

Comment 1

9 years ago
Fixed, although I don't know how to test it (echoing the variable in the shell looks ok):
http://hg.mozilla.org/mozilla-build/rev/ed6f5555b355
Assignee: nobody → ted.mielczarek
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

9 years ago
Thanks Ted, I don't have a "trunk" mozillaBuild to test that but here's how I saw this one : 
- svn checkout http://google-axsjax.googlecode.com/svn/trunk/ google-axsjax-re
ad-only (for example)
- cd google-axsjax-read-only
- vim Makefile (add some # below the license block)
- svn diff Makefile (gives "svn: Les donn?\195?\169es s?\195?\187res '--- Makefile  (r' sont suivies de l'octet non ASCII 195: conversion de/vers UTF-8 impossible")

with APR_ICONV_PATH set :
- svn diff Makefile (gives the correct diff)
(Assignee)

Comment 3

9 years ago
Here's a pre-release build with this fix for you to try:
http://people.mozilla.com/~tmielczarek/MozillaBuildSetup-1.4pre.exe
(Reporter)

Comment 4

9 years ago
I tested the provided exe with the steps in comment #2 and it's OK, thanks

=> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.