454676 - mozillabuild should export APR_ICONV_PATH

Status: VERIFIED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Régis Caspar]

svn cannot be used (encoding problems when trying to diff) with an out of the box mozillabuild install. We should export APR_ICONV_PATH = $MOZILLABUILD\\svn-win32-1.4.2\\iconv somewhere (/etc/profile?)

Comment 1

[(not currently active) Ted Mielczarek]

Fixed, although I don't know how to test it (echoing the variable in the shell looks ok):
http://hg.mozilla.org/mozilla-build/rev/ed6f5555b355

Comment 2

[Régis Caspar]

Thanks Ted, I don't have a "trunk" mozillaBuild to test that but here's how I saw this one : 
- svn checkout http://google-axsjax.googlecode.com/svn/trunk/ google-axsjax-re
ad-only (for example)
- cd google-axsjax-read-only
- vim Makefile (add some # below the license block)
- svn diff Makefile (gives "svn: Les donn?\195?\169es s?\195?\187res '--- Makefile  (r' sont suivies de l'octet non ASCII 195: conversion de/vers UTF-8 impossible")

with APR_ICONV_PATH set :
- svn diff Makefile (gives the correct diff)

Comment 3

[(not currently active) Ted Mielczarek]

Here's a pre-release build with this fix for you to try:
http://people.mozilla.com/~tmielczarek/MozillaBuildSetup-1.4pre.exe

Comment 4

[Régis Caspar]

I tested the provided exe with the steps in comment #2 and it's OK, thanks

=> VERIFIED