454710 - Need dummy variable in place of mPrefService in PreferencePaneBase.h (fragile base class problem)

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Chris Lawson (gone)]

Attachment: fix v1.0

Bug 384800 comment 40 et seq describes a branch crash with the new trunk PreferencePaneBase.h file compiled into CBSamplePane. Stuart suggested this fix in bug 428858 comment 7, and I just tested it and confirmed that I can't reproduce Smokey's branch crash with a new CBSamplePane.

Comment 1

[Stuart Morgan]

Comment on attachment 338001 [details] [diff] [review]
fix v1.0

>+  void* mPrefService; // dummy ivar to keep from breaking third-party preference panes
>+                      // deployed on both branch and trunk

Call it "dummy" or something equally obviously not for use (changing the name will also make it obvious to anyone trying to compile against trunk with code that was trying to use mPrefService before that they need to change their code).

Change the comment to: "placeholder for the old mPrefService variable, to prevent third-party preference panes deployed on both 1.x and 2+ from breaking due to the fragile base class problem."

r=me for the approach though (obviously ;) )

Comment 2

[Chris Lawson (gone)]

Attachment: fix v1.01

Updated for review comments.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 338013 [details] [diff] [review]
fix v1.01

sr=pink

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.