Closed
Bug 454720
Opened 17 years ago
Closed 17 years ago
Add GetThebesStyle and GetThebesWeight to gfxFontconfigUtils
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file)
|
6.04 KB,
patch
|
pavlov
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•17 years ago
|
||
I wrote these for bug 385263, but the FT2 code might as well also use the
weight translation. The FT2 code doesn't know the difference between oblique
and italic yet so I haven't changed it to use the style calculation.
I think the use of ranges rather than a case statement and rough estimate is
safer against new fontconfig predefined weights and other possible values from
fontconfig settings. FontFamily::FindFontEntry in gfxFT2Fonts.cpp will
truncate the 901 to 9 (and doesn't check that the result is within array
bounds).
Attachment #338021 -
Flags: review?(roc)
Attachment #338021 -
Flags: review?(roc) → review?(pavlov)
Comment on attachment 338021 [details] [diff] [review]
patch
I think Stuart needs to review this.
|
||
Updated•17 years ago
|
Attachment #338021 -
Flags: review?(pavlov) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Target Milestone: --- → mozilla1.9.1b1
You need to log in
before you can comment on or make changes to this bug.
Description
•