454720 - Add GetThebesStyle and GetThebesWeight to gfxFontconfigUtils

Status: RESOLVED FIXED

Description

[Karl Tomlinson (:karlt)]

Comment 1

[Karl Tomlinson (:karlt)]

Created attachment 338021 [details] [diff] [review]
patch

I wrote these for bug 385263, but the FT2 code might as well also use the
weight translation.  The FT2 code doesn't know the difference between oblique
and italic yet so I haven't changed it to use the style calculation.

I think the use of ranges rather than a case statement and rough estimate is
safer against new fontconfig predefined weights and other possible values from
fontconfig settings.  FontFamily::FindFontEntry in gfxFT2Fonts.cpp will
truncate the 901 to 9 (and doesn't check that the result is within array
bounds).

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 338021 [details] [diff] [review]
patch

I think Stuart needs to review this.

Comment 3

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/mozilla-central/rev/1aecd2a9914d