454744 - TM: "Assertion failure: PCVAL_IS_SPROP(entry->vword)" with getter

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js -j 
js> this.__defineGetter__('x', function() 2); for (var j=0;j<4;++j) { x=1; }

Assertion failure: PCVAL_IS_SPROP(entry->vword), at jstracer.cpp:4441

Comment 1

[Brendan Eich [:brendan]]

See bug 454689 and bug 454590 -- probably should dup but I want to patch first.

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Gonna land this on r=me authoritay.

/be

Comment 3

[Brendan Eich [:brendan]]

Fixed:

http://hg.mozilla.org/tracemonkey/rev/d01bf8dcae43
http://hg.mozilla.org/mozilla-central/rev/3a3f258dd951

/be

Comment 5

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/js1_5/extensions/regress-454744.js,v  <--  regress-454744.js
initial revision: 1.1

m-c: changeset:   19328:ae5a6fe1d588

The browser test throws TypeError: setting a property that has only a getter

Comment 6

[Bob Clary [:bc] (inactive)]

This test should have been in the 1.8 suite.

RCS file: /cvsroot/mozilla/js/tests/js1_8/extensions/regress-454744.js,v
done
Checking in js1_8/extensions/regress-454744.js;
/cvsroot/mozilla/js/tests/js1_8/extensions/regress-454744.js,v  <--  regress-454744.js
initial revision: 1.1
done
Removing js1_5/extensions/regress-454744.js;
/cvsroot/mozilla/js/tests/js1_5/extensions/regress-454744.js,v  <--  regress-454744.js
new revision: delete; previous revision: 1.1
done

http://hg.mozilla.org/mozilla-central/rev/af3f816c35d2