45477 - can't insert any html objects in composer

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[R.K.Aa.]

Linux build ID ..
when using "insert image" dialogue and having selected an image via filepicker,
an error displays:
"BUG!  neither radio button is checked!!!!"

Checking the first radion button (keep original size) and then clicking OK gives
yet an error:
"chrome://editor/content/EdImageProps.js line 480: globalElement has no
properties"

In brief - i can't find any way to insert an image in composer right now.

(Perhaps related: Clicking "fewer properties" return error same file line 145,
clicking around a little more and then "fewer properties" again give error in
line 229, clicking "edit imagemap" error in line 447, etc.)

Comment 1

[R.K.Aa.]

build ID 2000-071321

Comment 2

[rubydoo123]

this is quite a severe issue and it is not linux specific, assigning to brade

Comment 3

[Kathleen :Brade]

I wonder when this broke...

Are any other dialogs broken or just image?

Comment 4

[R.K.Aa.]

Probably lots of stuff broken - here some more:

When triggering "insert -> table" this appears:
JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIEditorShell.CreateElementWithDefaults]"
nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://editor/content/EdInsertTable.js :: Startup :: line 42"  data: no]

When clicking (a somewhat trucated) "Advanced" button in the "Insert Table"
dialogue, this appears:
JavaScript error:
chrome://editor/content/EdInsertTable.js line 95: dialog is not defined

When clicking OK after having set some table properties, the same error as above
displays. The dialoge does not dismiss, and consequently no table is inserted.

Comment 5

[R.K.Aa.]

When using insert link:
As dialog appears this error prints in console:
There is a selection: collapsed = true
JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIEditorShell.CreateElementWithDefaults]"
nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://editor/content/EdLinkProps.js :: Startup :: line 127"  data: no]

Clicking "Advanced Edit..." in the Inser Link dialog pops up an empty alert
window, with the text "Input error" on the titlebar.

Clicking "Choose File..." and then dismissing it gives error:
JavaScript error:
chrome://editor/content/EdDialogCommon.js line 785: fp.file has no properties

Comment 6

[Kathleen :Brade]

Yes, from my own quick tests, I don't seem to be able to insert any objects into 
the editor.  Upgrading this to "blocker" status.

Comment 7

[R.K.Aa.]

Can theoretically have broken well over a week ago? There was the "toolbar gets
disabled when typing in composer" bug, and the "can't open files with
filepicker" freeze-bug. During this time it wasn't possible to do much testing
in composer.

Comment 8

[Kathleen :Brade]

updating summary since this affects more than images; I've narrowed down the 
checkin that broke this.

This will affect composer and anything else that wants to insert html tags.

Comment 9

[sujay]

I can insert objects in 7/13 build..this must have regressed from checkins
last nite....

Comment 10

[Kathleen :Brade]

yes, the regression happened yesterday afternoon

Comment 11

[Kathleen :Brade]

reassign to tony

Comment 12

[anthonyd]

doh. fix checked in.

Comment 13

[R.K.Aa.]

Works fine again now. linux 2000-071520

Comment 14

[sujay]

verified in 7/17 build.