454774 - make install doesn't work on Solaris

Status: RESOLVED INCOMPLETE

(Firefox Build System :: General, defect)

Description

[Ginn Chen]

/usr/bin/find on Solaris doesn't have -xtype option.
"-type f" is same to "-xtype f" on both Linux and Solaris.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 3

[Benjamin Smedberg]

xtype is most definitely not the same as type. xtype dereferences any symlinks before checking the type, while type doesn't. xtype is not part of the posix standard, but -L is, so perhaps we should use that?

Comment 4

[Ginn Chen]

Comment on attachment 338081 [details] [diff] [review]
patch

Oops, I misread the manpage.

But find -L ... -type f doesn't work as expected, either.

Comment 5

[Ginn Chen]

the difference of
find -L . -type f
and
find . -xtype f
is the latter won't enter a symbolic directory.

We have such a link at dist/include, it is system_wrappers.

I think we don't want to install system_wrappers, at least we don't flatten it, because it would overwrite the real header.

so maybe we should use
find -L $(DIST)/include -type f ! -wholename '*/system_wrapers/*' ...

Comment 6

[Ginn Chen]

BTW:

We have vorbis/codec.h and theora/codec.h, oggz/config_win32.h and oggplay/config_win32.h.

We could not install both into one directory.

Comment 9

[Gregory Szorc [:gps]]

9 year old bug involving Solaris. There is litting value in keeping this open.