454781 - Mochitest doesn't align the names of the testfiles and test results

Status: VERIFIED FIXED

(Testing :: Mochitest, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Put filenames to the same <tr> with test results

It is very difficult to see which test fails because the results aren't in the
same line with filenames. The patch puts filenames to the same line with
results.
I didn't remove or change linksToTableRows() because it is used also elsewhere.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: this one

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: screenshot - without the patch

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: screenshot - with the patch

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Uh, --chrome tests do something different and the patch make that even uglier.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: fixes also --chrome [Checkin: Comment 12 & 13]

Now all the callers of linksToTableRows are fixed

Comment 6

[Justin Dolske [:Dolske]]

Backed out, reopening.

Apparently this was the cause of leakage on moz2-win32-slave07/08. They're replacing qm-win2k3-moz2-01 (which has also been mostly orange from leaks), although other platforms and qm-win2k3-03 were not leaking. Who knew?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

ugh. Really. It means that we have a leak bug somewhere if a web page (mochitest)
can trigger it.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Justin, which test was leaking, mochitest or chrome?

Comment 9

[Justin Dolske [:Dolske]]

The leak was in the Mochitest run... For an example, see:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1222299875.1222302701.18816.gz&fulltext=1#err0

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

I relanded this. There has been some leak fixes, hopefully fixing the
problems the patch revealed.
Not marking fixed before I've got leak results from windows tboxes.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Didn't work. Backed out.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Tried to reland, since this is *very* annoying bug.
The patch does still apply cleanly.
http://hg.mozilla.org/mozilla-central/rev/04cb4a9e893b

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 338831 [details] [diff] [review]
fixes also --chrome
[Checkin: Comment 12 & 13]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0efac62f1a94

Comment 14

[Aaron Train [:aaronmt]]

Verified FIXED

Ran mochitests on both latest trunk and branch, spotted the patched alignment.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090601 Shiretoko/3.5pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090601 Minefield/3.6a1pre