Closed
Bug 454818
Opened 16 years ago
Closed 16 years ago
AVMPLUS_PROFILE, -Ddprofile, and -Dsprofile are bitrot
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: edwsmith, Unassigned)
Details
Attachments
(1 file)
86.54 KB,
patch
|
stejohns
:
review+
|
Details | Diff | Splinter Review |
these are old and bitrotted, lets remove them entirely.
Reporter | ||
Comment 1•16 years ago
|
||
And, AVMPLUS_INTERP as a switch should be removed, it's always true and totally untested as false.
Comment 2•16 years ago
|
||
+1, I'll review+ that patch in a heartbeat :-)
Comment 3•16 years ago
|
||
Are there any other feature-style flags in avmbuild.h or mmgc.h that are obsolete and should be pruned too?
Comment 4•16 years ago
|
||
It would be helpful to upload the patch in here so that everybody can easily see.
Reporter | ||
Comment 5•16 years ago
|
||
Of course, patch will be attached once it's ready for review.
Reporter | ||
Comment 6•16 years ago
|
||
Attachment #339805 -
Flags: review?(stejohns)
Updated•16 years ago
|
Attachment #339805 -
Flags: review?(stejohns) → review+
Reporter | ||
Comment 7•16 years ago
|
||
pushed changeset: 917:07523d6fb971
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 8•15 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•