454830 - Experimental add-on login prompt when already logged in

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Rey Bango]

Attachment: Screencap of AMO experimental login while already logged in

I went to the following URL which is for an experimental add-on:

https://addons.mozilla.org/en-US/firefox/search?q=LowBrowse&cat=all

I noticed that it wouldn't allow me to add it to FF and presented the following message: "Log in to install this experimental add-on. Why? "

If you look at the attached screencap, you can see that I was actually logged in to AMO.

Comment 1

[Rey Bango]

Additionally, when I clicked on the login link presented on that page, it redirected me to the AMO homepage and did not offer an opportunity to login. The AMO homepage still showed me as logged in with editor and admin tool links visible.

Comment 2

[Fred Wenzel [:wenzel]]

That looks to me like a flaw in the element caching code, which does not seem to make a difference between logged in and not logged in users. In fact, I am not sure if we should cache the entire list element anymore once bug 425315 is in place.

Comment 4

[Fred Wenzel [:wenzel]]

As stated in bug 449667, this can happen in the opposite direction too. Without having looked at all the code, I am quite certain this occurs due to element caching, as I did not see anything preventing the element from being cached between logged out and logged in users.

I will switch off element caching for add-on list items shortly.

Comment 5

[Fred Wenzel [:wenzel]]

Switched off in SVN, r18626.

Pulling into 4.0.2 milestone, marking push-needed.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:22?show=100&exp=on&sort=name.