Created attachment 338173 [details] emphasize everywhere The location bar highlights everything that matches, and this can confuse users what's actually being matched, so scanning results can be tricky. By default, we're matching on word boundaries, so we should highlight those.
Created attachment 338174 [details] emphasize boundaries
Created attachment 338176 [details] [diff] [review] v1 Do the conservative boundary matching like nsNavHistoryAutoComplete.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #338176 - Flags: review?
Attachment #338176 - Flags: review? → review?(gavin.sharp)
Comment on attachment 338176 [details] [diff] [review] v1 Ed asked me to take a look at this. I think it's fine, although it yields false positives for extended or non-ASCII chars. Also, it might make sense to fall back to all matches when no word boundary match was found.
Attachment #338176 - Flags: review+
Created attachment 340332 [details] [diff] [review] v1.1 (In reply to comment #3) > Also, it might make sense to fall back to all matches Updated patch to use all matches when no boundaries are found. Also do some LICM for assumeBoundary.
Created attachment 340338 [details] [diff] [review] v1.2 Do the logic to decide if we should use boundary or all matches on a search term basis.
Resetting to NEW. Set back to ASSIGNED with an assignee, if you're working on this.
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.