Closed Bug 454870 Opened 16 years ago Closed 6 years ago

Reduce unwanted emphasis by only showing word boundary matches

Categories

(Firefox :: Address Bar, defect)

Product:
Firefox
Component:
Address Bar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INACTIVE

People

(Reporter: Mardak, Unassigned)

Details

Attachments

(3 files, 2 obsolete files)

emphasize everywhere
68.28 KB, image/png
Details
emphasize boundaries
67.37 KB, image/png
Details
v1.2
2.78 KB, patch
Details | Diff | Splinter Review
Attached image emphasize everywhere — 
The location bar highlights everything that matches, and this can confuse users what's actually being matched, so scanning results can be tricky.

By default, we're matching on word boundaries, so we should highlight those.
Attached image emphasize boundaries — 

        Attachment #338174 -
        Flags: ui-review?(beltzner)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1 (obsolete)
        — 
          — Splinter Review
      

    


  
Do the conservative boundary matching like nsNavHistoryAutoComplete.
Assignee: nobody → edilee
Status: NEW → ASSIGNED

        Attachment #338176 -
        Flags: review?

    
  

        Attachment #338176 -
        Flags: review? → review?(gavin.sharp)

    
    

    
  
Comment on attachment 338176 [details] [diff] [review]
v1

Ed asked me to take a look at this.

I think it's fine, although it yields false positives for extended or non-ASCII chars. Also, it might make sense to fall back to all matches when no word boundary match was found.

        Attachment #338176 -
        Flags: review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1.1 (obsolete)
        — 
          — Splinter Review
      

    


  
(In reply to comment #3)
> Also, it might make sense to fall back to all matches
Updated patch to use all matches when no boundaries are found. Also do some LICM for assumeBoundary.

        Attachment #338176 -
        Attachment is obsolete: true

        Attachment #340332 -
        Flags: review?(gavin.sharp)

        Attachment #338176 -
        Flags: review?(gavin.sharp)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1.2
        — 
          — Splinter Review
      

    


  
Do the logic to decide if we should use boundary or all matches on a search term basis.

        Attachment #340332 -
        Attachment is obsolete: true

        Attachment #340338 -
        Flags: review?(gavin.sharp)

        Attachment #340332 -
        Flags: review?(gavin.sharp)

    
  
Assignee: edilee → nobody

    
  

        Attachment #338174 -
        Flags: ui-review?(beltzner)

    
  

        Attachment #340338 -
        Flags: review?(gavin.sharp)

    
    

    
  
Resetting to NEW. Set back to ASSIGNED with an assignee, if you're working on this.
Status: ASSIGNED → NEW

    
    

    
  
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: