454938 - Memcaching unit tests should not use real memcached

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, defect, P3)

Description

[Fred Wenzel [:wenzel]]

The current tests for the basic memcaching model all rely on an actual memcache server in the background. We don't need that, and it may corrupt data if pointed at a real-world server -- using a mock object would be better.

Comment 1

[Fred Wenzel [:wenzel]]

I need to push this out of the current milestone due to its big dependency tree :(

Comment 2

[Wil Clouser [:clouserw]]

As long as we're namespacing the test data why is it a problem?

Comment 3

[Fred Wenzel [:wenzel]]

Maybe because you need an actual memcache server to run the tests, but that's okay. Also, I seem to remember the memcache tests flush the cached data at times, which should really not be done on a production server.

Comment 4

[Wil Clouser [:clouserw]]

Requiring memcache is fine, but flushing production isn't good.  I was just concerned using a mock object might be different enough that it won't make for effective tests.  I don't think we want to require a test memcache server either though.

Comment 5

[Wil Clouser [:clouserw]]

We should revisit how this is setup with amo:v4

Comment 6

[Jeff Balogh (:jbalogh)]

(In reply to comment #5)
> We should revisit how this is setup with amo:v4

django.core.cache can write to multiple backends, including memcached, files, and a dummy cache.  But the examples of "advanced" websites that I've seen have been using the underlying memcached API, so we'll probably just end up mocking it.  Good news: that's really easy!

Comment 7

[Fred Wenzel [:wenzel]]

Zamboni handles tests involving caching very well now.