Closed Bug 454979 Opened 13 years ago Closed 13 years ago

Text in Library's Search box isn't vertically centered

Categories

(Firefox :: Theme, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.1b2

People

(Reporter: wladow, Assigned: wladow)

Details

(Keywords: polish, Whiteboard: [polish-easy][polish-visual][polish-p2])

Attachments

(5 files, 1 obsolete file)

Attached image screenshot - Win Vista
Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1b1pre) Gecko/20080910043000 Minefield/3.1b1pre

Library window -> Search box -> text is not vertically centered, needs to go 1px down
Summary: Text in Library's Search box in not vertically centered → Text in Library's Search box isn't vertically centered
Whiteboard: [polish-easy][polish-visual][polish-high-visibility]
This might be effecting all search boxes, since it is a common control that we use.  If so, then definitely [polish-high-visibility]
Component: Bookmarks & History → XUL Widgets
OS: Windows Vista → All
Product: Firefox → Toolkit
QA Contact: bookmarks → xul.widgets
OS: All → Windows Vista
The appearance appears to be correct on OS X 10.4
I don't see it on Win XP either.
Attached patch restore css padding (obsolete) — Splinter Review
It seems this is Vista only and Library only issue, other search boxes are fine. 

This patch makes it look like any other search box, this code has been removed in bug 449375, so restoring and adjusting a little bit.
Attachment #346975 - Flags: review?(dao)
Assignee: nobody → wladow
Target Milestone: --- → mozilla1.9.1
Comment on attachment 346975 [details] [diff] [review]
restore css padding

nit: 0 instead of 0px

And the padding you're adding should take RTL into account.

But are you sure this is all needed? Please try if this works:

#searchFilter {
  padding-top: 3px;
  padding-bottom: 2px;
}

And please add a brief comment explaining why we're doing this.
Attachment #346975 - Flags: review?(dao) → review-
Component: XUL Widgets → Theme
Product: Toolkit → Firefox
QA Contact: xul.widgets → theme
Target Milestone: mozilla1.9.1 → ---
This also needs to be tested with a Classic theme.
Attached patch add css paddingSplinter Review
OK, this is default theme only issue, classic is fine even without this patch applied. This patch works fine with both default and classic theme.
Attachment #346975 - Attachment is obsolete: true
Attachment #347166 - Flags: review?(dao)
Comment on attachment 347166 [details] [diff] [review]
add css padding

there's a trailing space after {
Attachment #347166 - Flags: review?(dao) → review+
(In reply to comment #10)
> (From update of attachment 347166 [details] [diff] [review])
> there's a trailing space after {

err, after }, the closing bracket
Attached patch for checkinSplinter Review
Attachment #347168 - Flags: approval1.9.1b2?
Comment on attachment 347168 [details] [diff] [review]
for checkin

a=beltzner, this can go in before or after b2
Attachment #347168 - Flags: approval1.9.1b2? → approval1.9.1b2+
Pushed: http://hg.mozilla.org/mozilla-central/rev/701ef90e9563
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.
Whiteboard: [polish-easy][polish-visual][polish-high-visibility] → [polish-easy][polish-visual][polish-p2]
You need to log in before you can comment on or make changes to this bug.