454979 - Text in Library's Search box isn't vertically centered

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Vlado Valastiak [:wladow]]

Attachment: screenshot - Win Vista

Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1b1pre) Gecko/20080910043000 Minefield/3.1b1pre

Library window -> Search box -> text is not vertically centered, needs to go 1px down

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

This might be effecting all search boxes, since it is a common control that we use.  If so, then definitely [polish-high-visibility]

Comment 2

[Shawn Wilsher :sdwilsh]

The appearance appears to be correct on OS X 10.4

Comment 3

[Dão Gottwald [:dao]]

I don't see it on Win XP either.

Comment 4

[Vlado Valastiak [:wladow]]

Attachment: restore css padding

It seems this is Vista only and Library only issue, other search boxes are fine. 

This patch makes it look like any other search box, this code has been removed in bug 449375, so restoring and adjusting a little bit.

Comment 5

[Vlado Valastiak [:wladow]]

Attachment: screenshot: with patch applied

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 346975 [details] [diff] [review]
restore css padding

nit: 0 instead of 0px

And the padding you're adding should take RTL into account.

But are you sure this is all needed? Please try if this works:

#searchFilter {
  padding-top: 3px;
  padding-bottom: 2px;
}

And please add a brief comment explaining why we're doing this.

Comment 7

[Dão Gottwald [:dao]]

This also needs to be tested with a Classic theme.

Comment 8

[Vlado Valastiak [:wladow]]

Attachment: add css padding

OK, this is default theme only issue, classic is fine even without this patch applied. This patch works fine with both default and classic theme.

Comment 9

[Vlado Valastiak [:wladow]]

Attachment: classic theme with patch applied

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 347166 [details] [diff] [review]
add css padding

there's a trailing space after {

Comment 11

[Dão Gottwald [:dao]]

(In reply to comment #10)
> (From update of attachment 347166 [details] [diff] [review])
> there's a trailing space after {

err, after }, the closing bracket

Comment 12

[Vlado Valastiak [:wladow]]

Attachment: for checkin

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 347168 [details] [diff] [review]
for checkin

a=beltzner, this can go in before or after b2

Comment 14

[Dave Townsend [:mossop]]

Pushed: http://hg.mozilla.org/mozilla-central/rev/701ef90e9563

Comment 15

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.