455038 - The spinner should disappear when not spinning

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David Ascher (:davida)]

The spinner in the top right of all windows should disappear when static.

Comment 1

[Phil Ringnalda (:philor)]

I was going to claim that this was both not a regression (since we've never disappeared them), and that it should be Mac-only (since that's the only platform with a native throbber that disappears when it's inactive), but when I went looking for Windows and Linux throbbers that stay still, I found that IE now only does tab-throbbers that turn into the favicon, and Evolution's throbber is in a statusbar/panel that disappears, taking the throbber with it, when it's inactive, so the only things I found with non-disappearing throbbers were Firefoxes.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

=TRIAGE=
This reminds me of bug 471014, not sure if they are actually related.
Moving this to the rc1 milestone in hopes this is easy and we can get this out as a polish bug.

Comment 3

[David Ascher (:davida)]

Attachment: patch

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 363024 [details] [diff] [review]
patch

That makes it invisible while customizing, both on the toolbar and in the palette. Take a(n acquisitive) look at http://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/browser/browser.css#1467 instead.

Comment 5

[David Ascher (:davida)]

Attachment: v2

this seems to work better.  There are some unrelated issues re: the vertical alignment of the quick search textbox (esp. when not using Icons + Text), but they belong in a separate patch

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 369179 [details] [diff] [review]
v2

>-    <toolbaritem id="throbber-box"
>+    <toolbaritem id="navigator-throbber" title="&throbberItem.title;" 

Though that was just what Dão wanted to do for Fx, since they wanted to force the throbber off everyone's toolbar in new _and_ existing profiles, while leaving it in the palette so diehard old fogeys could put it back, surely that's not what you want to do to us?

>+#wrapper-navigator-throbber #navigator-throbber {

Child selector rather than descendant, please. #wrapper-navigator-throbber > #navigator-throbber only has to look one level up in the DOM every time a #navigator-throbber has style resolved; #wrapper-navigator-throbber #navigator-throbber has to look all the way up to the top of the DOM.

Comment 7

[Phil Ringnalda (:philor)]

What you *can* do, though, is piggy-back on bug 474523 - if you land together, the new defaultset for the new toolbar id can include navigator-throbber rather than throbber-box.

Comment 8

[David Ascher (:davida)]

Attachment: patch v3

In order to keep the id that's persisted in everyone's toolbar state, but also move to the image instead of the button (which I'm not sure why it seemed necessary for pinstripe, but it did at the time), I had to tweak the XUL id, and as a result tweak CSS on all themes.

Phil, is there a shorter version of this patch that would work?

Bryan, I have no idea how this looks on Vista/7.

Comment 9

[Phil Ringnalda (:philor)]

Attachment: v.4

Review comments, in the form of a patch:

- you had the right idea removing all the cruft in Pinstripe, though you didn't go quite far enough since the background-color was cruft too

- qute and gnomestripe needed the same decrufting, since anything other than a width plus some margin on the sides and a min-height and the list-image is cruft, either from dealing with the non-button button or from other longer-gone causes, particularly the [iconsize="small"] and [mode="text"] bits, which are copy-paste leftovers from the suite's big ol' 32x32 default throbber

I built on Linux, XP, Win7, and Mac, and compared before and after screenshots, so at least I'll be surprised by the inevitable "throbber looks wrong when you foo on bar" bug.

I'd be happier if we were going to wind up with the same id as Fx, but that would only really work if we did it by doing per-tab throbbers and thus wanted to remove the toolbar one by default; maybe next time around we can do that.

Comment 10

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/88d6866d2f23

Comment 11

[Alfred Kayser]

It would be nicer if the toolbaritem gets the id of the old button element: navigation-throbber (just like in Firefox), so that it is easier to maintain theme compatibility with older versions of TB and with FF itself.

Comment 12

[Phil Ringnalda (:philor)]

Alfred, I take it you didn't read comment 6 through comment 9?