Need to be able to pan fully while zoomed in

VERIFIED FIXED in fennec1.0a1

Status

Fennec Graveyard
Panning/Zooming
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Stuart Parmenter, Assigned: Gavin)

Tracking

Trunk
fennec1.0a1
x86
Windows Vista
Bug Flags:
blocking-xul-fennec1.0 +

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
_constrainPanCoords doesn't currently take in to account the zoom factor which means we overly constrain how far we can pan, which makes panning while zoomed quite painful.
Flags: blocking-fennec1.0+
(Reporter)

Updated

9 years ago
Target Milestone: --- → Fennec A1
Created attachment 338488 [details] [diff] [review]
patch

This makes sure we only pass page coords to constrainPanCoords, and includes some other simplifications. Kinetic is really broken with this, though, since it compares dragX/Y and pageX/Y which are screen coordinates and content (page) coordinates, respectively. I tried figuring out what the kinetic code is trying to do, but I didn't end up getting anywhere - I've just disabled it for now.
Created attachment 338742 [details] [diff] [review]
startKinetic uses helper functions
(Reporter)

Updated

9 years ago
Attachment #338742 - Flags: review+
http://hg.mozilla.org/mobile-browser/rev/538ad8727b55
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
verified with beta3
Status: RESOLVED → VERIFIED
Component: General → Panning/Zooming
You need to log in before you can comment on or make changes to this bug.