Closed
Bug 455220
Opened 17 years ago
Closed 9 years ago
Nitpick with ENABLE_TESTS in toolkit/components/feeds
Categories
(Toolkit Graveyard :: Build Config, defect)
Toolkit Graveyard
Build Config
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: glandium, Unassigned)
Details
Attachments
(1 file)
|
559 bytes,
patch
|
benjamin
:
review-
|
Details | Diff | Splinter Review |
toolkit/components/feeds is apparently the only place where tests are run on make check despite ENABLE_TESTS being undefined. While this is pretty stupid to run make check when configure --disable-tests was run before, it is surely unexpected to still have some tests running.
Attachment #338523 -
Flags: review?(benjamin)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 338523 [details] [diff] [review]
patch
We should instead add a toplevel error if you run check in a build with tests disabled.
Attachment #338523 -
Flags: review?(benjamin) → review-
|
||
Comment 2•9 years ago
|
||
toolkit/components/feeds no longer has a Makefile. So this is no longer an issue.
bsmedberg's comment about erroring if you run `check` without tests enabled might still be relevant. But considering we are splitting up `make check`, it's not worth keeping the bug open for.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
|
||
Updated•7 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•