Closed Bug 455221 Opened 11 years ago Closed 11 years ago

graphic glitch on invitations-pane

Categories

(Calendar :: Lightning Only, defect)

Lightning 0.9
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: thetux.moz, Assigned: thetux.moz)

Details

Attachments

(2 files, 2 obsolete files)

Attached image Screenshot
The invitations-pane hasn't the same background color as the mode-toolbox. If a scrollbar is shown, it looks like a glitch (see screenshot).
Attached patch Fix for the lightning.css file (obsolete) — Splinter Review
Attachment #338526 - Flags: ui-review?(christian.jansen)
Attachment #338526 - Flags: review?
Attachment #338526 - Flags: review? → review?(philipp)
Attachment #338526 - Flags: review?(philipp) → review+
Comment on attachment 338526 [details] [diff] [review]
Fix for the lightning.css file


>-#ltnSidebar,
>-#invitations-pane {
>-  background: -moz-field;  
>+#ltnSidebar {
>+	background: -moz-field;  
Please expand the tab to spaces. Also while you're at it, I'd prefer using background-color: instead of background:

>+#invitations-pane {
>+  background: -moz-dialog;  
Same here.


r=philipp codewise, now its up to christian if the looks are wanted.
We need this change for winstripe _and_ pinstripe, although I don't know how the label looks on a Mac.
Assignee: nobody → thetux.moz
Status: NEW → ASSIGNED
Attachment #338526 - Attachment is obsolete: true
Attachment #338536 - Flags: review+
Attachment #338526 - Flags: ui-review?(christian.jansen)
Attachment #338525 - Flags: ui-review?(christian.jansen)
Attachment #338536 - Attachment is obsolete: true
Attachment #338537 - Flags: review+
Attachment #338525 - Flags: ui-review?(christian.jansen) → ui-review+
Comment on attachment 338525 [details]
Screenshot

ui=christian
Keywords: checkin-needed
Whiteboard: [checkin-needed after 0.9]
Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/3a2b64bc09bc>
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [checkin-needed after 0.9]
Target Milestone: --- → 1.0
checked in lightning build 20081015052201 -> VERIFIED
Status: RESOLVED → VERIFIED
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.