Last Comment Bug 455222 - All XUL <script>s must have type="application/javascript"
: All XUL <script>s must have type="application/javascript"
Status: RESOLVED FIXED
: regression
Product: SeaMonkey
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
-- major (vote)
: seamonkey2.0a1
Assigned To: neil@parkwaycc.co.uk
:
:
Mentors:
Depends on:
Blocks: 381467
  Show dependency treegraph
 
Reported: 2008-09-14 07:51 PDT by neil@parkwaycc.co.uk
Modified: 2008-09-17 22:20 PDT (History)
5 users (show)
kairo: blocking‑seamonkey2.0a1+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Proposed patch (13.09 KB, patch)
2008-09-14 07:57 PDT, neil@parkwaycc.co.uk
no flags Details | Diff | Splinter Review
Ex x- (13.04 KB, patch)
2008-09-14 08:51 PDT, neil@parkwaycc.co.uk
iann_bugzilla: review+
mkmelin+mozilla: review+
Details | Diff | Splinter Review

Description User image neil@parkwaycc.co.uk 2008-09-14 07:51:03 PDT
... otherwise you can't use the latest JavaScript features.

For example, the Search Messages dialog can't open a message folder because the function is in a file that uses the "let" keyword, so marking as a regression.
Comment 1 User image neil@parkwaycc.co.uk 2008-09-14 07:57:50 PDT
Created attachment 338528 [details] [diff] [review]
Proposed patch

I omitted preftree.xul because that's dying.

I think some of these files are shared with Thunderbird so asking for 2 reviews.
Comment 2 User image Karsten Düsterloh 2008-09-14 08:11:41 PDT
Shouldn't that be application/javascript, as per bug 381467?
Comment 3 User image Shawn Wilsher :sdwilsh 2008-09-14 08:38:56 PDT
Er, I was specifically told (can't recall by who offhand) that application/javascript was the same as application/x-javascript, but that the latter should be considered depreciated...
Comment 4 User image neil@parkwaycc.co.uk 2008-09-14 08:50:23 PDT
OK, application/javascript it is.
Comment 5 User image neil@parkwaycc.co.uk 2008-09-14 08:51:20 PDT
Created attachment 338530 [details] [diff] [review]
Ex x-

I changed any existing types in those files too.
Comment 6 User image Shawn Wilsher :sdwilsh 2008-09-14 09:16:37 PDT
So, does application/javascript not let you use the latest features?  If so, we should get a bug on that :/
Comment 7 User image neil@parkwaycc.co.uk 2008-09-14 09:48:41 PDT
Either of the two types works, but omitting the type does not. Should it?
Comment 8 User image Shawn Wilsher :sdwilsh 2008-09-14 10:23:51 PDT
I don't think it should work with omitting the type (what about python scripts?)
Comment 10 User image Robert Kaiser 2008-09-14 15:55:52 PDT
I'm told the search messages dialog can't open the message folder due to this bug, so blocking+ sounds reasonable.
Comment 11 User image neil@parkwaycc.co.uk 2008-09-17 05:54:18 PDT
Pushed changeset c1f31d315bfa to mozilla-central.

Marking FIXED as this was only about untyped scripts.
Comment 12 User image Robert Kaiser 2008-09-17 06:01:26 PDT
(In reply to comment #11)
> Pushed changeset c1f31d315bfa to mozilla-central.

You surely mean comm-central: http://hg.mozilla.org/comm-central/rev/c1f31d315bfa ;-)

Note You need to log in before you can comment on or make changes to this bug.