Closed Bug 455239 Opened 11 years ago Closed 11 years ago

Switching from windowed to full screen, brings out control strip

Categories

(Firefox for Android Graveyard :: General, defect)

Other
Maemo
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: christian.bugzilla, Assigned: mfinkle)

References

()

Details

Attachments

(1 file)

When launching Fennec and using the hardware button to switch to full-screen mode, the control strip shows up when in full-screen mode.
Bah, BrowserUI._sizeControls was supposed to handle that
The reason I added _layoutControls flag & check was opening the panelUI was firing a window.resize event, which messed up the positioning of the controls. I guess I need to dig in and find the reason for the resize event being fired.
The iframed add-on manager and download manager are causing the extra "resize" events. We should be able to filter them based on the "window == aEvent.target"
This patch uses the event.target to see if ti's the main window or a sub window that is being resized. Some controls should only be positioned if the main window is being resized.
Assignee: nobody → mark.finkle
Attachment #338548 - Flags: review?(gavin.sharp)
Attachment #338548 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mobile-browser/rev/5fbad643ccf0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
The strip still shows when switching to full screen even though it does disappear again.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
So the redraw is too slow?
I have made a screencast (http://people.mozilla.com/~csejersen/fennec-resize.mov) that shows the problem. You can see that the control strip is briefly displayed while switching from windowed to full-screen.

I will file a separate bug for the two "resizes".
(In reply to comment #8)

> I will file a separate bug for the two "resizes".

It's been fixed. We filter now.
we no longer does this
I don't see any control strip when changing sizes anymore.
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
verfied with beta3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.