455239 - Switching from windowed to full screen, brings out control strip

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Christian Sejersen]

When launching Fennec and using the hardware button to switch to full-screen mode, the control strip shows up when in full-screen mode.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Bah, BrowserUI._sizeControls was supposed to handle that

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

The reason I added _layoutControls flag & check was opening the panelUI was firing a window.resize event, which messed up the positioning of the controls. I guess I need to dig in and find the reason for the resize event being fired.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

The iframed add-on manager and download manager are causing the extra "resize" events. We should be able to filter them based on the "window == aEvent.target"

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Checks the window to determine what controls to resize

This patch uses the event.target to see if ti's the main window or a sub window that is being resized. Some controls should only be positioned if the main window is being resized.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/5fbad643ccf0

Comment 6

[Christian Sejersen]

The strip still shows when switching to full screen even though it does disappear again.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

So the redraw is too slow?

Comment 8

[Christian Sejersen]

I have made a screencast (http://people.mozilla.com/~csejersen/fennec-resize.mov) that shows the problem. You can see that the control strip is briefly displayed while switching from windowed to full-screen.

I will file a separate bug for the two "resizes".

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #8)

> I will file a separate bug for the two "resizes".

It's been fixed. We filter now.

Comment 10

[Stuart Parmenter]

we no longer does this

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

I don't see any control strip when changing sizes anymore.

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

verfied with beta3