Closed
Bug 455320
Opened 17 years ago
Closed 17 years ago
[el] Change the url for eBay search plug-in
Categories
(Mozilla Localizations :: el / Greek, defect)
Mozilla Localizations
el / Greek
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: pkst)
Details
(Keywords: fixed1.9.0.5)
Attachments
(1 file)
|
1.31 KB,
patch
|
stas
:
review+
Pike
:
approval1.9.0.5+
|
Details | Diff | Splinter Review |
Due to some back-end changes, eBay has asked us to change the URL in the eBay search plugin.
Since the Greek localization uses the en-GB plug-in, please update it using the following URL:
http://rover.ebay.com/rover/1/710-47297-17704-2/4
and the following parameter:
<Param name="satitle" value="{searchTerms}"/>
All other parameters should be removed.
Thanks!
| Reporter | ||
Comment 1•17 years ago
|
||
Just a quick note:
Please attach patches with the change for current trunk (hg) and for Firefox 3.0.3 (cvs trunk). Both patches will need to be reviewed (you can set the requestee to me) and the cvs one will need to get an approval1.9.0.3 (please set this flag to '?').
Thanks!
| Assignee | ||
Comment 2•17 years ago
|
||
OK ready for trunk.
Sorry for the late response
Attachment #345729 -
Flags: review?(stas)
Attachment #345729 -
Flags: approval1.9.0.4?
| Reporter | ||
Updated•17 years ago
|
Attachment #345729 -
Flags: review?(stas)
Attachment #345729 -
Flags: review+
| Reporter | ||
Comment 3•17 years ago
|
||
Comment on attachment 345729 [details] [diff] [review]
patch for ebay search plugin
Thanks Kostas!
r=me. Please land this patch in hg referencing this bug and my review.
For 1.9.0.x branch (CVS), please wait for the approval.
BTW. Pike, shouldn't there be an approval1.9.0.5 already?
| Assignee | ||
Comment 4•17 years ago
|
||
OK thanks Stas-
patch landed in hg .
Updated•17 years ago
|
Attachment #345729 -
Flags: approval1.9.0.4? → approval1.9.0.5?
Updated•17 years ago
|
Attachment #345729 -
Flags: approval1.9.0.5?
Comment 5•17 years ago
|
||
Comment on attachment 345729 [details] [diff] [review]
patch for ebay search plugin
a=me, please land with a check-in comment referencing this bug and stas' review as well as my approval. Use the fixed1.9.0.5 and verified1.9.0.5 keywords to track landing and testing.
Attachment #345729 -
Flags: approval1.9.0.5? → approval1.9.0.5+
| Reporter | ||
Comment 6•17 years ago
|
||
Hi Kostas. Can you land the patch in CVS as well? We'd lke to get this change in 3.0.5 as well. Thanks! (Please mention my review and Axel's approval in the check-in comment.)
Comment 7•17 years ago
|
||
Landed on CVS, too.
Checking in eBay-en-GB.xml;
/l10n/l10n/el/browser/searchplugins/eBay-en-GB.xml,v <-- eBay-en-GB.xml
new revision: 1.2; previous revision: 1.1
done
Marking FIXED and fixed1.9.0.5.
Verification welcome.
| Reporter | ||
Comment 8•17 years ago
|
||
Thanks Axel.
You need to log in
before you can comment on or make changes to this bug.
Description
•