[sr] Change the url for eBay search plug-in

RESOLVED FIXED

Status

defect
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: stas, Assigned: filmil)

Tracking

({fixed1.9.0.7})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Due to some back-end changes, eBay has asked us to change the URL in the eBay search plugin.

Since the Serbian locale uses the en-GB plug-in, please update it using the following URL:
http://rover.ebay.com/rover/1/710-47297-17704-2/4

and the following parameter:
<Param name="satitle" value="{searchTerms}"/>

All other parameters should be removed.

Thanks!
(Assignee)

Updated

11 years ago
Assignee: nobody → filmil
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Reporter)

Comment 1

11 years ago
Please don't commit the change without a review from me or Axel (changes to web services, i.e. search plug-ins, default RSS readers etc. need to be reviewed even for trunk).

Also, we'd like to make this change in 3.0.3, so Filip, could you prepare a patch for CVS trunk please? (it will need a r+ and approval1.9.0.3 to land).

Thanks!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 2

11 years ago
Filip, any updates? It would be great to land this by tomorrow's code freeze for 3.0.4. Please let me know if I can help you.
(Assignee)

Comment 3

11 years ago
Here's a belated fix for this.  Sorry for the delay, the request came in a very inappropriate time for me, so it took a while to actually cater to it.
Attachment #356363 - Flags: review?(l10n)
Attachment #356363 - Flags: approval1.9.0.7?

Comment 4

10 years ago
Comment on attachment 356363 [details] [diff] [review]
Patches the Serbian ebay search plugin for 3.0.x

a=me for 3.0.7, sorry for the belated review/approval. Can you get this landed today?

Please land with a check-in comment referencing this bug and my review and approval, and use the fixed1.9.0.7 and verified1.9.0.7 keywords to track landing and testing.
Attachment #356363 - Flags: review?(l10n)
Attachment #356363 - Flags: review+
Attachment #356363 - Flags: approval1.9.0.7?
Attachment #356363 - Flags: approval1.9.0.7+
(Reporter)

Comment 5

10 years ago
Landed in CVS before today's 3.0.7 code freeze:
Checking in browser/searchplugins/eBay-en-GB.xml;
/l10n/l10n/sr/browser/searchplugins/eBay-en-GB.xml,v  <--  eBay-en-GB.xml
new revision: 1.4; previous revision: 1.3
done

Filip, can you take care of 3.1 and 3.2 branches (on hg)? Thanks!
Keywords: fixed1.9.0.7
(Assignee)

Updated

10 years ago
Status: REOPENED → ASSIGNED
(Assignee)

Comment 6

10 years ago
I just gave it a check --- the 3.1 and 3.2 already have the fix applied.  So, closing this bug fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.