455328 - [gl] Change the url for eBay search plug-in

Status: RESOLVED FIXED

(Mozilla Localizations :: gl / Galician, defect)

Description

[Staś Małolepszy :stas]

Due to some back-end changes, eBay has asked us to change the URL in the eBay search plugin.

Please update it using the following URL:
http://rover.ebay.com/rover/1/1185-51955-19398-1/4

and the following parameter:
<Param name="satitle" value="{searchTerms}"/>

All other parameters should be removed.

Thanks!

Comment 1

[Staś Małolepszy :stas]

Just a quick note:

Please attach patches with the change for current trunk (hg) and for Firefox 3.0.3 (cvs trunk). Both patches will need to be reviewed (you can set the requestee to me) and the cvs one will need to get an approval1.9.0.3 (please set this flag to '?').

Thanks!

Comment 2

[Suso Baleato]

Just tell me which is the file to change and I'll do it.

Comment 3

[Staś Małolepszy :stas]

The file is:
http://mxr.mozilla.org/l10n-central/source/gl/browser/searchplugins/eBay-es.xml

(same for /l10n/, i.e. CVS)

Since Galician uses the eBay-in-Spain plug-in, the change should be the same as the one that happened for es-ES and eu, which should make things easier. An example diff is:
http://hg.mozilla.org/l10n-central/es-ES/rev/d4478e3390ea

Thanks Suso!

Comment 4

[Suso Baleato]

Attachment: Patched Search eBay xml

Thanks to you Stás! As this is my very first former patch, let me be a little more verbose than I must :)

1. I made the changes (taking as reference the eu version) manually editing my last copy of the tree. Then I created the diff following the "instructions on how to submit a patch" link.

2. Now I'm attaching the patch trying to follow your instructions but:
- Selected the patch checkbox
- approval1.9.0.3 is not there (I think that's my fault by beeing so late with this) so I selected approval1.9.0.5
- Requestee: I set the flat to '?' and wrote there r=stas, don't know if that's exactly the sintaxis
- I doubt to do a reassignment, taking the bug and changing status to assigned. As I'm not sure, I stay the thing as it is.

3. Well; that's all. Just tell me if this is ok, and if not, I'll try to do it better next time.

Thanks! :)

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 349558 [details] [diff] [review]
Patched Search eBay xml

r/a=me. Please land this with a check-in comment referencing this bug and my review and approval. This should have been getting a positive review before landing on hg, too.

A good comment would something like "bug 455328, update URL for eBay search plugin, r,a=[e-mail]"

Please land this in CVS, too, as a separate check-in from bug 466293. Use the fixed1.9.0.5 keyword to denote landing on CVS, and change that to verified1.9.0.5 once it's tested and verified on nightly builds for 3.0.5pre.

Comment 6

[Suso Baleato]

Landed to CVS with that comment, and including that keyword in the comment as well.

Comment 7

[Suso Baleato]

Changed bugzilla keyword to fixed1.9.0.5.

(In reply to comment #5)

> 
> Please land this in CVS, too, as a separate check-in from bug 466293. Use the
> fixed1.9.0.5 keyword to denote landing on CVS,

landed and bugzilla keyword fixed1.9.0.5 added

> and change that to
> verified1.9.0.5 once it's tested and verified on nightly builds for 3.0.5pre.

OK.

Comment 8

[Suso Baleato]

Axel, in order to commit that testing just two quick questions:

- Can you confirm me that the building will appear here:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.9.0-l10n/

- When might I expect the gl build for testing? Not sure if that date is the schedule's building start date because in the previous URI I found some builds made at 15-Nov-2008 and others 24-Nov-2008

Thanks in advance,

Comment 9

[Suso Baleato]

Hi,(In reply to comment #5)
> Use the fixed1.9.0.5 keyword to denote landing on CVS, and change that to
> verified1.9.0.5 once it's tested and verified on nightly builds for 3.0.5pre.

Sucessfull compiled (thanks Axel); I downloaded 3.0.5pre (24/11/08, 21:18:00) and tested it. eBay Search is now using "rover" correctly instead of "search". 

Changing keyword to verified1.9.0.5. Just tell me in case I need to do more stuff on this.

Comment 10

[Staś Małolepszy :stas]

Thank you so much Suso, and Axel for the review. Sorry for not being around during past few days. Closing this bug per comment 9.