455330 - [gu-IN] Change the url for eBay search plug-in

Status: RESOLVED FIXED

(Mozilla Localizations :: gu-IN / Gujarati, defect)

Description

[Staś Małolepszy :stas]

Due to some back-end changes, eBay has asked us to change the URL in the eBay search plug-in.

Please update it using the following URL:
http://rover.ebay.com/rover/1/4686-51949-19398-1/4

and the following parameter:
<Param name="satitle" value="{searchTerms}"/>

All other parameters should be removed.

Thanks!

Comment 1

[Ankit Patel]

which parameter needs to be updated in the ebay.xml file?

I mean for http://rover.ebay.com/rover/1/4686-51949-19398-1/4 url...

Comment 2

[Staś Małolepszy :stas]

It's the 'template' attribute of the <Url/> element:

http://hg.mozilla.org/l10n-central/gu-IN/file/d122e923b2c1/browser/searchplugins/eBay-in.xml#l6 (line 6)

Comment 3

[Staś Małolepszy :stas]

Just a quick note:

Please attach a patch with the change for current trunk (hg) and for Firefox 3.0.3 (cvs trunk). Both patches will need to be reviewed (please set the review flag to '?' and put [e-mail] in the requestee field) and the cvs one will need to get an approval1.9.0.3 (please set this flag to '?').

Thanks!

Comment 4

[Ankit Patel]

Attachment: Patch for eBay-in.xml taken from CVS Trunk for Fx 3.0.x

Hi Stats,

Please review the patch. So, if it gets approve we can land it asap.

Thanks!

Comment 5

[Ankit Patel]

Attachment: Patch for eBay-in.xml taken from Hg Trunk for Fx 3.1.x

Hi Stats,

Please review the patch. So, if it gets approve we can land it asap.

Thanks!

Comment 6

[Staś Małolepszy :stas]

Comment on attachment 339200 [details] [diff] [review]
Patch for eBay-in.xml taken from CVS Trunk for Fx 3.0.x

Please remove all other <params/> except for <Param name="query" value="{searchTerms}"/>.

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 339201 [details] [diff] [review]
Patch for eBay-in.xml taken from Hg Trunk for Fx 3.1.x

Please remove all other <params/> except for <Param name="query" value="{searchTerms}"/>.

Thanks!

Comment 8

[Ankit Patel]

Attachment: Patch for eBay-in.xml taken from CVS Trunk for Fx 3.0.x

Stats, pls review it again...

Thanks!

Comment 9

[Ankit Patel]

Attachment: Patch for eBay-in.xml taken from Hg Trunk for Fx 3.1.x

Stats,

Pls review it again!

Thx!

Comment 10

[Ankit Patel]

Ping...

Comment 11

[Staś Małolepszy :stas]

Comment on attachment 339459 [details] [diff] [review]
Patch for eBay-in.xml taken from CVS Trunk for Fx 3.0.x

>   <Param name="query" value="{searchTerms}"/>

The correct param name is "satitle". I'll make a new patch.

Comment 12

[Staś Małolepszy :stas]

Comment on attachment 339461 [details] [diff] [review]
Patch for eBay-in.xml taken from Hg Trunk for Fx 3.1.x

ditto

Comment 13

[Staś Małolepszy :stas]

Attachment: Fixed the param name to satitle

No need to go through the whole patch-r?-r+ cycle, I'm sure you have other things to do :) This should be OK. The patch was prepared against revision d122e923b2c1, so you'll probably need to back out the change you've already made.

This patch can also be used in CVS (with -p1 or more).

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 339798 [details] [diff] [review]
Fixed the param name to satitle

a=me for 3.0.3, please land with a check-in comment referencing this bug and stas' review/my approval. Use the fixed1.9.0.3 and verified1.9.0.3 keywords to track landing and testing.

Comment 15

[Samuel Sidler (old account; do not CC)]

This needs to land by tomorrow, Friday, October 24 at 11:59pm if it's going to make this cycle.

Comment 16

[Ankit Patel]

I think I have already landed this patch in the "Hg" system...

http://hg.mozilla.org/l10n-central/gu-IN/rev/4cd7584595c9

But the mistake I did was the comment. The comment I put for this patch is "Updated already"... I know it's a stupid comment, but how can we change the comment now...

Apologies for making a mistake in the comments...

Comment 17

[Samuel Sidler (old account; do not CC)]

Ankit, this was approved for the 1.9.0 branch (CVS HEAD). If you don't want it there, I can clear that flag.

Comment 18

[Staś Małolepszy :stas]

I checked the patch in to the CVS.

Checking in eBay-in.xml;
/l10n/l10n/gu-IN/browser/searchplugins/eBay-in.xml,v  <--  eBay-in.xml
new revision: 1.4; previous revision: 1.3
done

Please verify this in a nightly build. Thanks!