455333 - [pa-IN] Change the url for eBay search plug-in

Status: RESOLVED FIXED

(Mozilla Localizations :: pa-IN / Punjabi, defect)

Description

[Staś Małolepszy :stas]

Due to some back-end changes, eBay has asked us to change the URL in the eBay search plug-in.

Please update it using the following URL:
http://rover.ebay.com/rover/1/4686-51949-19398-1/4

and the following parameter:
<Param name="satitle" value="{searchTerms}"/>

All other parameters should be removed.

Thanks!

Comment 1

[A S Alam]

can you please mention about version you want to fix for this?
3.0.2 or 3.x or all?

Comment 2

[Staś Małolepszy :stas]

We're targeting 3.0.3 and 3.x so this should land on hg trunk with r+ and on cvs trunk with r+ and approval1.9.0.3. Thanks :)

Comment 3

[A S Alam]

Attachment: patch for pa-IN cvs 3.0.x

Comment 4

[A S Alam]

hg (3.x) - it is commited with changes to trunk

Comment 5

[Axel Hecht [:Pike]]

Please don't commit before you actually got review on patches to search engines.

Comment 6

[Staś Małolepszy :stas]

As Axel said, we normally ask to provide patches for review for changes to search plugins (even on trunk). 

Please indent the <Param name="satitle" value="{searchTerms}"/> with two spaces
both in hg and in the patch for cvs. It greatly improves the readability of the
xml :)

Thanks!

Comment 7

[A S Alam]

Attachment: Patch for pa-IN cvs 3.x

Comment 8

[A S Alam]

Attachment: Patch for pa-IN cvs 3.0.x

Comment 9

[Staś Małolepszy :stas]

Thanks for the patches. The change looks good (template and param), but could you use two-space indentation for <param/>, please? Makes things easier to read :)

Comment 10

[Staś Małolepszy :stas]

Forgot to say: once you update the patches, please request a review from [e-mail].

Comment 11

[A S Alam]

+   <Param name="satitle" value="{searchTerms}"/>
I already put 3 space before this (in patch after +), but I don't think I understand what you want, can you please update me where actually you want 2 spaces?

Comment 12

[Staś Małolepszy :stas]

I meant 2 spaces instead of 3 before <Param ... />. I know this is nitpicking, but it really makes a difference in the longer run. Thanks!

Comment 13

[A S Alam]

Attachment: Patch for pa-IN cvs 3.0.x

ok, it is updated

Comment 14

[A S Alam]

Attachment: Patch for pa-IN HG 3.x

Comment 15

[Staś Małolepszy :stas]

Comment on attachment 339445 [details] [diff] [review]
Patch for pa-IN cvs 3.0.x

r=me.

Comment 16

[Staś Małolepszy :stas]

Comment on attachment 339446 [details] [diff] [review]
Patch for pa-IN HG 3.x

r=me. Thanks.

Comment 17

[Axel Hecht [:Pike]]

Comment on attachment 339445 [details] [diff] [review]
Patch for pa-IN cvs 3.0.x

a=me for 3.0.3. Please land this with a check-in comment referencing this bug
and my approval and stas' review.

Please use the fixed1.9.0.3 and verified1.9.0.3 keywords to track landing and
testing.

Comment 18

[A S Alam]

1.9.0.3 Commited for CVS as below..
----
Checking in searchplugins/eBay-in.xml;
/l10n/l10n/pa-IN/browser/searchplugins/eBay-in.xml,v  <--  eBay-in.xml
new revision: 1.4; previous revision: 1.3
done
-----

HG commit: (it is what exactly in cvs)
changeset:   7:96a2ceb178cf

Comment 19

[Staś Małolepszy :stas]

Resolving fixed per comment 18. Thanks!