All users were logged out of Bugzilla on October 13th, 2018

[pa-IN] Change the url for eBay search plug-in

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: stas, Assigned: amanpreet.alam)

Tracking

({fixed1.9.0.4, verified1.9.0.4})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

10 years ago
Due to some back-end changes, eBay has asked us to change the URL in the eBay search plug-in.

Please update it using the following URL:
http://rover.ebay.com/rover/1/4686-51949-19398-1/4

and the following parameter:
<Param name="satitle" value="{searchTerms}"/>

All other parameters should be removed.

Thanks!
(Assignee)

Comment 1

10 years ago
can you please mention about version you want to fix for this?
3.0.2 or 3.x or all?
(Reporter)

Comment 2

10 years ago
We're targeting 3.0.3 and 3.x so this should land on hg trunk with r+ and on cvs trunk with r+ and approval1.9.0.3. Thanks :)
(Assignee)

Comment 3

10 years ago
Created attachment 338853 [details] [diff] [review]
patch for pa-IN cvs 3.0.x
Attachment #338853 - Flags: approval1.9.0.3?
(Assignee)

Comment 4

10 years ago
hg (3.x) - it is commited with changes to trunk

Comment 5

10 years ago
Please don't commit before you actually got review on patches to search engines.
(Reporter)

Comment 6

10 years ago
As Axel said, we normally ask to provide patches for review for changes to search plugins (even on trunk). 

Please indent the <Param name="satitle" value="{searchTerms}"/> with two spaces
both in hg and in the patch for cvs. It greatly improves the readability of the
xml :)

Thanks!
(Assignee)

Comment 7

10 years ago
Created attachment 339052 [details] [diff] [review]
Patch for pa-IN cvs 3.x
(Assignee)

Comment 8

10 years ago
Created attachment 339054 [details] [diff] [review]
Patch for pa-IN cvs 3.0.x
Attachment #338853 - Attachment is obsolete: true
Attachment #338853 - Flags: approval1.9.0.3?
(Assignee)

Updated

10 years ago
Attachment #339054 - Flags: approval1.9.0.3?
(Reporter)

Comment 9

10 years ago
Thanks for the patches. The change looks good (template and param), but could you use two-space indentation for <param/>, please? Makes things easier to read :)
(Reporter)

Comment 10

10 years ago
Forgot to say: once you update the patches, please request a review from stas@mozilla.com.
(Assignee)

Comment 11

10 years ago
+   <Param name="satitle" value="{searchTerms}"/>
I already put 3 space before this (in patch after +), but I don't think I understand what you want, can you please update me where actually you want 2 spaces?
(Reporter)

Comment 12

10 years ago
I meant 2 spaces instead of 3 before <Param ... />. I know this is nitpicking, but it really makes a difference in the longer run. Thanks!
(Assignee)

Comment 13

10 years ago
Created attachment 339445 [details] [diff] [review]
Patch for pa-IN cvs 3.0.x

ok, it is updated
Attachment #339054 - Attachment is obsolete: true
Attachment #339445 - Flags: review?(stas)
Attachment #339445 - Flags: approval1.9.0.3?
Attachment #339054 - Flags: approval1.9.0.3?
(Assignee)

Comment 14

10 years ago
Created attachment 339446 [details] [diff] [review]
Patch for pa-IN HG 3.x
Attachment #339052 - Attachment is obsolete: true
Attachment #339446 - Flags: review?(stas)
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 15

10 years ago
Comment on attachment 339445 [details] [diff] [review]
Patch for pa-IN cvs 3.0.x

r=me.
Attachment #339445 - Flags: review?(stas) → review+
(Reporter)

Comment 16

10 years ago
Comment on attachment 339446 [details] [diff] [review]
Patch for pa-IN HG 3.x

r=me. Thanks.
Attachment #339446 - Flags: review?(stas) → review+

Updated

10 years ago
Attachment #339445 - Flags: approval1.9.0.3? → approval1.9.0.3+

Comment 17

10 years ago
Comment on attachment 339445 [details] [diff] [review]
Patch for pa-IN cvs 3.0.x

a=me for 3.0.3. Please land this with a check-in comment referencing this bug
and my approval and stas' review.

Please use the fixed1.9.0.3 and verified1.9.0.3 keywords to track landing and
testing.
(Assignee)

Comment 18

10 years ago
1.9.0.3 Commited for CVS as below..
----
Checking in searchplugins/eBay-in.xml;
/l10n/l10n/pa-IN/browser/searchplugins/eBay-in.xml,v  <--  eBay-in.xml
new revision: 1.4; previous revision: 1.3
done
-----

HG commit: (it is what exactly in cvs)
changeset:   7:96a2ceb178cf
Keywords: fixed1.9.0.3, verified1.9.0.3
(Reporter)

Comment 19

10 years ago
Resolving fixed per comment 18. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.