Don't define or use DEBUG_$(shell whoami)

NEW
Assigned to

Status

--
minor
10 years ago
10 years ago

People

(Reporter: wtc, Assigned: wtc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

10 years ago
I suggest that NSPR's build system not define DEBUG_$(shell whoami)
(or its equivalent for platforms that don't have the 'whoami' command),
and we remove DEBUG_userid from the NSPR source tree.

The reason is that we need to process the user id if it contains
characters that are illegal in a macro name, such as spaces and
hyphens.  I never use DEBUG_wtc during development, and don't think
such conditionally compiled code should be checked in.

The NSPR source tree contains these DEBUG_userid macros:
DEBUG_warren
DEBUG_kipp
DEBUG_jwz
DEBUG_pedemonte
You need to log in before you can comment on or make changes to this bug.