Superfluous inactive window background style makes -moz-appearance faster

RESOLVED WORKSFORME

Status

()

Core
General
RESOLVED WORKSFORME
10 years ago
5 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

({perf})

Trunk
All
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

10 years ago
In bug 439354 I changed the unified toolbar to use a -moz-appearance instead of a background image for the gradient. This made the inactive window style for the toolbar background unnecessary:

-#main-window:not([active="true"]) > #navigator-toolbox > #nav-bar {
-  background-image: url("chrome://global/skin/toolbar/toolbar-background-inactive.png");
-}
 
However, removing this rule resulted in a 10% twinopen regression. I put it back in changeset ff469575e3ee.

In Stefan's words (on IRC):
> As it is now, this basically means "yeah, use '-moz-mac-unifiedtoolbar',
> but make sure to add css background style in order to avoid a 10% perf hit"

In fact, it doesn't make sense at all that a background style changes anything for a themed frame.
We should find out why this is the case and fix it properly.
(Assignee)

Updated

10 years ago
Blocks: 439354
(Assignee)

Comment 2

9 years ago
I think fixing bug 453541 will fix this.
Depends on: 453541
(Assignee)

Comment 3

5 years ago
This is probably not an issue any more.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.