Closed Bug 455601 Opened 16 years ago Closed 16 years ago

AMO Update 9/18

Categories

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Product:
Infrastructure & Operations Graveyard
Component:
WebOps: Other
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: morgamic, Assigned: oremj)

Details

We need to do a database upgrade and SVN update for AMO this Thursday to push changes from AMO 4.0.1.

Details will be added below.
Database will have to be altered:

ALTER TABLE `addons` ADD `higheststatus` TINYINT( 2 ) UNSIGNED NOT NULL DEFAULT '0' AFTER `status` ;
UPDATE addons SET higheststatus=status;
The SQL above needs to be run *before* the svn update.

bug 453924 should be with this update which is the stats monitoring script, so dm-stats01 will need to be updated as well, and nagios set to run check_stats.php daily to make sure there are no fails. I'll comment again if the script isn't in this update.
Assignee: server-ops → oremj
FWIW, r=stephend on the fixes I've tested and verified -- the rest of the backend stuff I'm writing Selenium tests for.
mysql> ALTER TABLE `addons` ADD `higheststatus` TINYINT( 2 ) UNSIGNED NOT NULL DEFAULT
    -> '0' AFTER `status` ;
Query OK, 7589 rows affected (1.34 sec)
Records: 7589  Duplicates: 0  Warnings: 0

mysql> UPDATE addons SET higheststatus=status;
Query OK, 7442 rows affected (0.27 sec)
Rows matched: 7589  Changed: 7442  Warnings: 0

 U   .

Fetching external item into 'site'
D    site/app/webroot/discussions
U    site/app/webroot/services/update.php
U    site/app/webroot/css/style.css
U    site/app/webroot/css/developers.css
U    site/app/webroot/css/screen.css
U    site/app/webroot/css/style.min.css
U    site/app/webroot/css/rustico.css
U    site/app/webroot/css/remora.css
U    site/app/webroot/.htaccess
A    site/app/webroot/img/developers/pencil.png
A    site/app/webroot/img/developers/status_nominate.png
A    site/app/webroot/img/developers/asterisk_yellow.png
A    site/app/webroot/img/developers/preview_edit.png
A    site/app/webroot/img/developers/preview_delete.png
A    site/app/webroot/img/developers/status_inactive.png
A    site/app/webroot/img/developers/status_active.png
A    site/app/webroot/img/developers/cross.png
A    site/app/webroot/img/developers/preview_add.png
U    site/app/webroot/js/developers.js
U    site/app/webroot/js/jquery.addons.min.js
U    site/app/webroot/js/__utm.min.js
U    site/app/locale/sv_SE/LC_MESSAGES/messages.mo
U    site/app/locale/sv_SE/LC_MESSAGES/messages.po
U    site/app/locale/uk/LC_MESSAGES/messages.mo
U    site/app/locale/uk/LC_MESSAGES/messages.po
U    site/app/locale/sq/LC_MESSAGES/messages.mo
U    site/app/locale/sq/LC_MESSAGES/messages.po
U    site/app/locale/da/LC_MESSAGES/messages.mo
U    site/app/locale/da/LC_MESSAGES/messages.po
U    site/app/locale/fa/pages/error404.thtml
U    site/app/locale/fa/LC_MESSAGES/messages.mo
U    site/app/locale/fa/LC_MESSAGES/messages.po
U    site/app/locale/de/LC_MESSAGES/messages.mo
U    site/app/locale/de/LC_MESSAGES/messages.po
U    site/app/locale/ja/LC_MESSAGES/messages.mo
U    site/app/locale/ja/LC_MESSAGES/messages.po
U    site/app/locale/he/LC_MESSAGES/messages.mo
U    site/app/locale/he/LC_MESSAGES/messages.po
U    site/app/locale/es_ES/LC_MESSAGES/messages.mo
U    site/app/locale/es_ES/LC_MESSAGES/messages.po
U    site/app/locale/fi/LC_MESSAGES/messages.mo
U    site/app/locale/fi/LC_MESSAGES/messages.po
U    site/app/locale/pt_BR/LC_MESSAGES/messages.mo
U    site/app/locale/pt_BR/LC_MESSAGES/messages.po
U    site/app/locale/fr/LC_MESSAGES/messages.mo
U    site/app/locale/fr/LC_MESSAGES/messages.po
U    site/app/locale/nl/LC_MESSAGES/messages.mo
U    site/app/locale/nl/LC_MESSAGES/messages.po
U    site/app/locale/pl/LC_MESSAGES/messages.mo
U    site/app/locale/pl/LC_MESSAGES/messages.po
U    site/app/locale/hu/LC_MESSAGES/messages.mo
U    site/app/locale/hu/LC_MESSAGES/messages.po
U    site/app/locale/ro/LC_MESSAGES/messages.mo
U    site/app/locale/ro/LC_MESSAGES/messages.po
U    site/app/locale/ca/LC_MESSAGES/messages.mo
U    site/app/locale/ca/LC_MESSAGES/messages.po
U    site/app/locale/tr/LC_MESSAGES/messages.mo
U    site/app/locale/tr/LC_MESSAGES/messages.po
U    site/app/locale/pt_PT/LC_MESSAGES/messages.mo
U    site/app/locale/pt_PT/LC_MESSAGES/messages.po
U    site/app/locale/ru/LC_MESSAGES/messages.mo
U    site/app/locale/ru/LC_MESSAGES/messages.po
U    site/app/locale/zh_TW/LC_MESSAGES/messages.mo
U    site/app/locale/zh_TW/LC_MESSAGES/messages.po
U    site/app/locale/id/LC_MESSAGES/messages.mo
U    site/app/locale/id/LC_MESSAGES/messages.po
U    site/app/locale/el/LC_MESSAGES/messages.mo
U    site/app/locale/el/LC_MESSAGES/messages.po
U    site/app/locale/zh_CN/LC_MESSAGES/messages.mo
U    site/app/locale/zh_CN/LC_MESSAGES/messages.po
U    site/app/locale/ga_IE/LC_MESSAGES/messages.mo
U    site/app/locale/ga_IE/LC_MESSAGES/messages.po
U    site/app/locale/cs/LC_MESSAGES/messages.mo
U    site/app/locale/cs/LC_MESSAGES/messages.po
U    site/app/locale/eu/LC_MESSAGES/messages.mo
U    site/app/locale/eu/LC_MESSAGES/messages.po
U    site/app/locale/en_US/pages/experimental_addons.thtml
U    site/app/locale/en_US/LC_MESSAGES/messages.mo
U    site/app/locale/en_US/LC_MESSAGES/messages.po
U    site/app/locale/ko/LC_MESSAGES/messages.mo
U    site/app/locale/ko/LC_MESSAGES/messages.po
U    site/app/locale/mn/LC_MESSAGES/messages.mo
U    site/app/locale/mn/LC_MESSAGES/messages.po
U    site/app/locale/it/LC_MESSAGES/messages.mo
U    site/app/locale/it/LC_MESSAGES/messages.po
U    site/app/locale/sk/LC_MESSAGES/messages.mo
U    site/app/locale/sk/LC_MESSAGES/messages.po
U    site/app/tests/models/memcaching_model.test.php
A    site/app/tests/app_controller.test.php
A    site/app/tests/facebook-selenium
A    site/app/tests/testSuite.html
U    site/app/tests/views/addons/display.test.php
U    site/app/tests/views/addons/home.test.php
A    site/app/tests/amo-selenium.html
U    site/app/tests/test_helper_unit.php
A    site/app/tests/controllers/admin_controller.test.php
U    site/app/tests/controllers/components/image.test.php
A    site/app/tests/search.html
U    site/app/tests/data/remora-test-data.sql
U    site/app/models/preview.php
U    site/app/models/addon.php
U    site/app/models/memcaching.php
U    site/app/models/platform.php
U    site/app/config/sql/remora.sql
U    site/app/config/bootstrap.php
U    site/app/config/revisions.php
U    site/app/config/language.php
U    site/app/app_model.php
U    site/app/controllers/admin_controller.php
U    site/app/controllers/statistics_controller.php
U    site/app/controllers/components/search.php
U    site/app/controllers/components/developers.php
U    site/app/controllers/components/diff.php
U    site/app/controllers/components/editors.php
U    site/app/controllers/components/rdf.php
U    site/app/controllers/components/amo.php
U    site/app/controllers/components/image.php
U    site/app/controllers/previews_controller.php
U    site/app/controllers/images_controller.php
U    site/app/controllers/developers_controller.php
G    site/app/controllers/addons_controller.php
U    site/app/controllers/facebook_controller.php
U    site/app/controllers/editors_controller.php
U    site/app/controllers/api_controller.php
U    site/app/app_controller.php
D    site/app/views/images
U    site/app/views/reviews/display.thtml
U    site/app/views/admin/serverstatus.thtml
U    site/app/views/admin/addons_status.thtml
U    site/app/views/admin/features.thtml
U    site/app/views/users/login.thtml
U    site/app/views/users/edit.thtml
U    site/app/views/helpers/listing.php
U    site/app/views/search/index.thtml
D    site/app/views/developers/addon_submit.thtml
D    site/app/views/developers/versions_add.thtml
U    site/app/views/developers/addon_status.thtml
U    site/app/views/developers/versions_delete.thtml
U    site/app/views/developers/addon_edit.thtml
U    site/app/views/developers/addon_edit_authors.thtml
U    site/app/views/developers/addon_edit_categories.thtml
U    site/app/views/developers/previews.thtml
A    site/app/views/developers/addon_status_confirm.thtml
U    site/app/views/developers/addon_edit_properties.thtml
U    site/app/views/developers/index.thtml
A    site/app/views/developers/addon_submit_choose.thtml
U    site/app/views/developers/versions.thtml
A    site/app/views/developers/uploader.thtml
U    site/app/views/developers/versions_edit.thtml
U    site/app/views/developers/addon_edit_descriptions.thtml
A    site/app/views/developers/addon_status_nominate.thtml
U    site/app/views/developers/details.thtml
U    site/app/views/developers/edit.thtml
A    site/app/views/developers/dashboard.thtml
U    site/app/views/addons/home.thtml
U    site/app/views/addons/versions.thtml
U    site/app/views/addons/category_landing.thtml
U    site/app/views/addons/searchengines.thtml
U    site/app/views/addons/browse.thtml
U    site/app/views/addons/themes_landing.thtml
U    site/app/views/addons/recommended.thtml
U    site/app/views/addons/browse_thumbs.thtml
U    site/app/views/addons/previews.thtml
U    site/app/views/addons/display.thtml
U    site/app/views/facebook/install.thtml
U    site/app/views/editors/featured.thtml
U    site/app/views/editors/review.thtml
U    site/app/views/api/api_addon.thtml
U    site/app/views/elements/recaptcha.thtml
U    site/app/views/elements/addon_version_detail.thtml
A    site/app/views/elements/developers/sidebar.thtml
U    site/app/views/elements/developers/addonheader.thtml
U    site/app/views/elements/developers/editbox.thtml
U    site/app/views/elements/developers/myaddons.thtml
U    site/app/views/elements/developers/actionbar.thtml
U    site/app/views/elements/developers/statsbar.thtml
U    site/app/views/elements/developers/translationbox.thtml
Updated external to revision 18361.


Fetching external item into 'bin'
A    bin/check_stats.php
Updated external to revision 18361.


Fetching external item into 'site/vendors/product-details'
U    site/vendors/product-details/productDetails.class.php
U    site/vendors/product-details/firefoxDetails.class.php
Updated external to revision 18329.

Updated to revision 18390.
> G    site/app/controllers/addons_controller.php

local changes?
Looks like we made a local change that was committed.  There are no more local changes.
Also, I'll do the stats/nagios stuff tomorrow.
Nevermind, there is one local change:

Index: site/app/controllers/addons_controller.php
===================================================================
--- site/app/controllers/addons_controller.php	(revision 18361)
+++ site/app/controllers/addons_controller.php	(working copy)
@@ -72,7 +72,8 @@
     */
     function display($id = null) {
         global $valid_status;
-        
+
+        $this->forceShadowDb();
         $this->Amo->clean($id);
 
         $this->publish('bigHeader', true);
@@ -416,7 +417,8 @@
      */
     function browse() {
         global $app_listedtypes, $hybrid_categories;
-        
+
+        $this->forceShadowDb();
         if (!isset($this->namedArgs['type'])) {
             // @TODO throw a 404 error
             $this->redirect('/');
(In reply to comment #2)
> The SQL above needs to be run *before* the svn update.
> 
> bug 453924 should be with this update which is the stats monitoring script, so
> dm-stats01 will need to be updated as well, and nagios set to run
> check_stats.php daily to make sure there are no fails. I'll comment again if
> the script isn't in this update.

Do you want nagios alerts or just daily e-mails?
The impression I got from the email thread was that IT would have nagios monitor the scripts and if it was something they can't fix (though most problems are related to logs) they would hand off to webdev.

morgamic, what do you think?
The documentation and monitor script was all done specifically so IT can monitor them.  We can watch #sysadmins as well for stats mess-ups.  Don't think we need the emails, but someone should get them in case we need to look at the output to debug when nagios cries.
Reed, please create the monitor mentioned in comment 2.
Assignee: oremj → reed
Summary: AMO Update 9/18 → Create AMO Stats Monitor
Nagios check added for new stats script.
Assignee: reed → oremj
Summary: Create AMO Stats Monitor → AMO Update 9/18
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Component: Server Operations: Web Operations → WebOps: Other
Product: mozilla.org → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.