455614 - "ASSERTION: We got null for |e| but MatchElementId found something?" moving svg:pattern many times

Status: RESOLVED WORKSFORME

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: We got null for |e| but MatchElementId found something?: '!eDebug', file /Users/jruderman/central/content/base/src/nsDocument.cpp, line 3306

This code is part of liveness infrastructure roc added in bug 344258.

Comment 1

[Mats Palmgren (inactive)]

It's a race between mutation observers.  The assertion occurs when we run
nsSVGPatternElement::ContentAppended (which calls GetElementByIdInternal)
before nsDocument::ContentAppended (which registers the ID).
There is a nsIdentifierMapEntry::FireChangeCallbacks which is called
for ID changes but AFAICT there is nothing leading back to SVG to
update the SVG element through that route, so I think nsSVGPatternElement
isn't doing what it should for this notification which I suppose could
lead to bad rendering.

Maybe we could fire nsSVGPatternElement::PushUpdate() async to
guarantee all mutation observers are done?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

this should be fixed with my paint-server update in bug 455984.

Comment 3

[Robert Longson [:longsonr]]

Don't see this any more so I guess bug 455984 probably did fix it.