455691 - TM: test_empty_body.js httpd.js test fails under JIT

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Robert Sayre]

I run it like this, from $OBJDIR/netwerk/test/httpserver:

%> TRACEMONKEY=verbose NATIVE_TOPSRCDIR="/Users/sayrer/dev/tracemonkey" TOPSRCDIR="/Users/sayrer/dev/tracemonkey" gdb ../../../dist/bin/xpcshell
...
(gdb) run -j -s -f /Users/sayrer/dev/tracemonkey/tools/test-harness/xpcshell-simple/head.js -f ../../../_tests/xpcshell-simple/test_necko/test/head_utils.js -f ../../../_tests/xpcshell-simple/test_necko/test/test_empty_body.js -f /Users/sayrer/dev/tracemonkey/tools/test-harness/xpcshell-simple/tail.js -f /Users/sayrer/dev/tracemonkey/tools/test-harness/xpcshell-simple/execute_test.js

I can get it to succeed under JIT by inserting print statements such that the loop near line 3529 is not traced.

Comment 1

[Andreas Gal :gal]

which file is line 3529 relative to?

Comment 2

[Robert Sayre]

It is httpd.js, in nsHttpHeaders.enumerator.

Comment 3

[Andreas Gal :gal]

Strange. Without my push/pop patch (which is waiting for review and is not yet committed) that loop shouldn't trace:

  get enumerator()
  {
    var headers = [];
    for (var i in this._headers)
    {
      var supports = new SupportsString();
      supports.data = i;
      headers.push(supports);
    }

    return new nsSimpleEnumerator(headers);
  }

Comment 4

[Robert Sayre]

Attachment: reduced version

Here's a version that runs alone in xpcshell. The loop is at line 264. Note that it contains a print() call and an array.push, both of which should abort the trace. Curiously, uncommenting a print() call just below the loop close does abort the trace. See comments in attachment.

%> TRACEMONKEY=verbose ./xpcshell -j -f /Users/sayrer/Desktop/test_loop.js

Comment 5

[Robert Sayre]

ok, so it looks like this exits trace to do the inner loop, and then re-enters. possible?

Comment 6

[Robert Sayre]

headers.enumerator returns undefined in _end(), which causes the test to throw an exception.

Comment 7

[Andreas Gal :gal]

I assume this works now?

Comment 8

[Robert Sayre]

Fixed by http://hg.mozilla.org/tracemonkey/rev/034e02267810

Comment 9

[Robert Sayre]

(In reply to comment #8)
> Fixed by http://hg.mozilla.org/tracemonkey/rev/034e02267810

Oops, wrong. Fixed by

http://hg.mozilla.org/tracemonkey/rev/3090e1560262

bug 453462.

Comment 10

[Bob Clary [:bc] (inactive)]

test in js1_8_1/trace/trace-test.js

Comment 11

[Bob Clary [:bc] (inactive)]

v 1.9.1, 1.9.2